[
https://issues.apache.org/jira/browse/TOBAGO-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215603#comment-13215603
]
Udo Schnurpfeil commented on TOBAGO-986:
----------------------------------------
I've tested the last patch bommel in the current 1.5.4-SNAPSHOT and added a
testing page to here: http://localhost:8080/faces/tc/sheet/sheet-sort.xhtml
It looks good, so I've committed the patch.
I think the patch from bommel is a little bit more appropriate than the patch
from helmut in one case: when you have 2 components in the column: one command
and one output than the output will be priorized.
> Sheet can only sort UIOutput - Nothing happend with UILinkCommand and
> UIButtonCommand
> -------------------------------------------------------------------------------------
>
> Key: TOBAGO-986
> URL: https://issues.apache.org/jira/browse/TOBAGO-986
> Project: MyFaces Tobago
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.35
> Reporter: Sven Bunge
> Assignee: Bernd Bohmann
> Priority: Minor
> Fix For: 1.0.36, 1.5.0-beta-1, 1.5.0
>
> Attachments:
> Patch_for_TOBAGO-986__Make_UILinkCommand_and_UIButtonCommand_sortable.patch,
> TOBAGO-986.patch
>
>
> If a column in a sheet is filled with a tc:link (UILinkCommand) or tc:button
> (UIButtonCommand) the Sorter-class is unable to sort the sheet.
> There are several problems with the method Sorter#getFirstSortableChild(..):
> * The children of a UICommand are recursive searched for a tc:out -> the
> algorithm look into the tc:link and tc:button.
> * Only tc:out's are returned from the method
> * .. the caller method invoke(..) get only the value-binding named "value" -
> The UILinkCommand and UIButtonCommand have no value-field.
> I optimized the getFirstSortableChild(..)-Method and introduced a new method
> how returns the ValueBinding.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
