UICommand.queueEvent description changed since 2.0
--------------------------------------------------

                 Key: MYFACES-3255
                 URL: https://issues.apache.org/jira/browse/MYFACES-3255
             Project: MyFaces Core
          Issue Type: Bug
            Reporter: Leonardo Uribe
            Assignee: Leonardo Uribe


Checking some javadoc for JSF 2.2 "viewAction", I notice our implementation of 
UICommand.queueEvent does not match with the documentation since JSF 2.0.

Before:

public void queueEvent(FacesEvent e)

    Intercept queueEvent and, for ActionEvents, mark the phaseId for the event 
to be PhaseId.APPLY_REQUEST_VALUES if the immediate flag is true, 
PhaseId.INVOKE_APPLICATION otherwise.

After:

public void queueEvent(FacesEvent e)

    Intercept queueEvent and take the following action. If the event is an 
ActionEvent, obtain the UIComponent instance from the event. If the component 
is an ActionSource obtain the value of its "immediate" property. If it is true, 
mark the phaseId for the event to be PhaseId.APPLY_REQUEST_VALUES otherwise, 
mark the phaseId to be PhaseId.INVOKE_APPLICATION. The event must be passed on 
to super.queueEvent() before returning from this method.


Tracking this one I found this issue:

http://java.net/jira/browse/JAVASERVERFACES-622

Since it was added after 1.2 rev A and before 2.0, myfaces code still does what 
the spec says since 1.2. Anyway,  we should change MyFaces code to follow the 
javadoc description.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to