Hello Andy,

Just minor comments.

1. Can ChangeManagerWrapper implement the FacesWrapper<T> interface?
2. I would just call the delegate getter "getWrapped()" instead of getWrappedChangeManager() if we don't use 1 or a similar variant. wdyt?

Thanks
Pavitra

On 3/9/2011 12:55 PM, Andy Schwartz wrote:
Gang -

I would like to add a new base class for ChangeManager wrapper classes
to extend as discussed here:

https://issues.apache.org/jira/browse/TRINIDAD-2055

I have attached an implementation to the issue:

https://issues.apache.org/jira/secure/attachment/12473198/ChangeManagerWrapper.java

Fairly simple stuff, but would appreciate if someone could review.

On a related note...

As a new committer, I am a bit fuzzy on what the process is for
introducing new APIs. My guess is that any significant APIs require
discussion/community approval (maybe even a vote?).  Is the same true
of simple/small APIs like this?  (If there is documentation on this
that I need to read, please let me know!)

Thanks,
Andy

Reply via email to