Hi Ali, I just committed your patch.
Regards, Jakob 2010/6/8 Ali Ok <[email protected]> > Here is the JIRA issue and the patch: > https://issues.apache.org/jira/browse/MYFACES-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > Thanks, > > On Tue, Jun 8, 2010 at 12:24 PM, Jakob Korherr <[email protected]>wrote: > >> Hi Ali, >> >> also +1 from me. >> >> The idea behind the XXXRendererBase classes on shared is that core and >> tomahawk use almost the same functionality here, tomahawk just adds one or >> more features to the existing behavior (like e.g. enabledOnUserRole). >> However you're right, it should be subdivided into better extendable parts >> rather than copied. >> >> Actually I am currently working on a little feature for Tomahawk 2.0 and I >> also was annoyed about this. So please create the JIRA issue and submit the >> patch. Maybe it will also help me with my work :) >> >> Regards, >> Jakob >> >> 2010/6/8 Matthias Wessendorf <[email protected]> >> >> On Tue, Jun 8, 2010 at 9:17 AM, Ali Ok <[email protected]> wrote: >>> > Hi, >>> > myfaces-shared HtmlTextRendererBase >>> > : >>> http://svn.apache.org/repos/asf/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlTextRendererBase.java >>> > >>> > tomahawk HtmlTextRenderer >>> > : >>> http://svn.apache.org/repos/asf/myfaces/tomahawk/trunk/core20/src/main/java/org/apache/myfaces/renderkit/html/ext/HtmlTextRenderer.java >>> > I saw these two long before, and decided to not to follow that >>> approach. >>> > Files are almost identical, even if one extends another. >>> > As you see, shared HtmlTextRendererBase is not much extensible, ie. not >>> > fragmented into atomic parts or smthg. >>> > I want to use that base in my project too. So I made very simple >>> > modifications on that class: divided the long renderInput method into >>> two >>> > protected methods without changing the behavior. >>> > Is it ok to do that? >>> >>> sure, big methods are always a pita. >>> >>> > I will create a JIRA ticket and post the patch. >>> >>> +1 >>> >>> -M >>> >>> > And I just wonder why authors kept that long method and copy-pasted it >>> on >>> > Tomahawk? Is there something I'm not aware of? >>> > Regards, >>> > -- >>> > My Blog: http://blog.aliok.com.tr >>> > Twitter: http://twitter.com/aliok_tr >>> > >>> > >>> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ >>> sessions: http://www.slideshare.net/mwessendorf >>> twitter: http://twitter.com/mwessendorf >>> >> >> >> >> -- >> Jakob Korherr >> >> blog: http://www.jakobk.com >> twitter: http://twitter.com/jakobkorherr >> work: http://www.irian.at >> > > > > -- > My Blog: http://blog.aliok.com.tr > Twitter: http://twitter.com/aliok_tr > > -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
