Hi,
please review simple patch
https://issues.apache.org/jira/browse/TRINIDAD-1596.
More question about Resource support in trinidad2:
1) JSF 2 introduced "name" and "library" as an alternative to "src",
"image" or "icon" for example. According to tag library documentation
there is support only on h:graphicImage, but surprisingly it works with
h:commandButton too (and maybe other).
Should trinidad support name and library with tr:image (an alternative
to h:graphicImage)?
If a component has exactly one image attribute ("icon" in trinidad)
interpret name/library as alternative to it ? I think "name" and
"library" are too generic - they should be named "iconName" and
"iconLibrary" or something like that.
Folowing components have icon attribute:
CoreInputListOfValues
CorePanelBox
CorePanelHeader
CorePanelPopup
CoreShowDetailHeader
CoreCommandButton
CoreCommandNavigationItem
CoreGoButton
I dont really understand if name/library concept was intended for
components without behaviour from 'resource' family like image or CSS.
2) HTML head section
There are h:outputStylesheet and h:outputScript in JSF 2.0 . Both
support name and library attrs too. If we will rework trinidad2 to
Resource API is there any reason why add to trh:styleSheeet
name/library support?
I think trh: tags can remain for JSP/old application and without
name/library attrs and for new trinidad2/Facelets based application
users can use new tags from JSF 2.0
Note: name/library are only a option to #{resource} implicit object.
Regards,
Martin
