+1 on that clean up.
Sent from my iPod.
Am 15.10.2008 um 00:31 schrieb Gabrielle Crawford <[EMAIL PROTECTED]
>:
Hi,
As far as I can tell, the UIXCookie tz and accessibility mode values
are either never set, or if set, never used. I believe both were
used in the past but have become obsolete. I'm therefore planning to
remove UIXCookie.
Let me know if there are objections.
Thanks,
Gabrielle
Gabrielle Crawford (JIRA) wrote:
remove UIXCookie as the values are no longer used
-------------------------------------------------
Key: TRINIDAD-1261
URL: https://issues.apache.org/jira/browse/TRINIDAD-1261
Project: MyFaces Trinidad
Issue Type: Bug
Reporter: Gabrielle Crawford
UIXCookie seems to be dead code that should be removed.
UIXCookie is supposed to supports the following state:
* The accessibility mode chosen by the user
* The TimeZone of the user
As far as I can tell, the info on the cookie for the tz and
accessibility mode are never used.
TimeZone
* Server: UIXCookie.setTimeZone, the only way to assign
the UIXCookie tz, is never called on the server.
* Client: There is a script written to the client in
HeadRenderer, which on the client writes tz info
into the uixcookie. However this value is never used
on either the client or server. It used to be used on
the server in RequestContextImpl.getTimeZone, but that
code has been commented out long ago.
* Conclusion: We're needlessly writing out a cookie script
when the value set on the client is never used.
Accessibility Mode
* Server: UIXCookie.setAccessibilityMode, the only way to
assign the UIXCookie accessibility mode, is never called
* Client: I see no references on the client to the
accessibility mode cookie value.
* Conclusion: I don't see how the mode could be set on
the cookie. Andy Schwartz, who has worked extensively
on accessibility issues, thinks this is old code that is no
longer in use.
