[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634577#action_12634577
 ] 

Paul Rivera commented on TOMAHAWK-1183:
---------------------------------------

I've attached the revised set of test cases above as testcases2.rar.

Changes made:
  - the workaround for shale-test
  - consistent license headers
  - new test cases for sandbox 1.1 and sandbox 1.2
  - test results

I've created new issues for uncovered bugs:
MYFACES-1981
TOMAHAWK-1335
TOMAHAWK-1337
TOMAHAWK-1340
TOMAHAWK-1342
TOMAHAWK-1343

All of them already have patches available.

After applying their patches, ALL test cases provided above will succeed.

> inputCalendar setfocus not working
> ----------------------------------
>
>                 Key: TOMAHAWK-1183
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1183
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>         Environment: windows xp
>            Reporter: richard lee
>         Attachments: myfaces-shared-2.0.9.patch, myfaces-shared-3.0.4.patch, 
> testcases.rar, testcases2.rar, testExampleOverMyfacesImpl.patch, 
> tomahawk-1.1.7.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The inputCalendar tag / component is not rendering javascript entered for the 
> setfocus property. I'm attempting to add some custom javascript to the 
> setfocus of an inputcalendar to be run when the user clicks in the input box 
> associated with the calendar, but this is being ignored during the redering 
> of the input box. The only javascript that gets rendered is the "standard" 
> javascript , i.e. onfocus="selectText('null', 'con9n')".
> I believe the issue is in HtmlTextHelpRenderer:
> if(isSelectText(component))
>             {
>                 HtmlRendererUtils.renderHTMLAttributes(writer, component,
>                                                        
> HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK);
>                 writer.writeAttribute(HTML.ONFOCUS_ATTR,
>                                       
> HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
>                                       getHelpText(component) + "', '" + id 
> +"')", null);
>                 writer.writeAttribute(HTML.ONCLICK_ATTR,
>                                       
> HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
>                                       getHelpText(component) + "', '" + id 
> +"')", null);
>             }
> when writing out the HTML.ONFOCUS_ATTR is should write out any user specified 
> onfocus attributes as well as the standard ones.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to