Yeah, I think in general we need to do a better job of committing patches. Let me say this though, if you think this is a blocking issue and needs to be addressed before 1.2.8, then it IS relevant to the release process and you should vote -1.
I for one am still voting +1 because although TRINIDAD-1059 is a pretty straight forward fix, Trinidad has never claimed to be compatible with non-firefox and ie browsers and I suspect we'd have other issues as well, especially with skinning. Furthermore some of the client-side javascript is based off this agent. If you don't think it's important enough to hold up the release, let's move this to another thread. Scott On Fri, May 16, 2008 at 4:35 AM, Alexey Stukalov <[EMAIL PROTECTED]> wrote: > > Hi, Scott > > Sorry if my comment is not relevant to the release process, just thought > that resolutions for > > http://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&sorter/order=DESC&sorter/field=priority&resolution=-1&pid=12310661&fixfor=12313041 > trinidad-1.2.8<http://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&sorter/order=DESC&sorter/field=priority&resolution=-1&pid=12310661&fixfor=12313041trinidad-1.2.8>issues > might be set prior the release. > > Specifically, http://issues.apache.org/jira/browse/TRINIDAD-1059 > TRINIDAD-1059<http://issues.apache.org/jira/browse/TRINIDAD-1059TRINIDAD-1059> > is a critical one, and a fix is a trivial one-liner. > > Thanks, > Alexey > > > Scott O'Bryan wrote: > > > > Hi, > > > > I was running the needed tasks to get the 1.2.8 release of the Apache > > MyFaces Trinidad out. The artifacts are deployed to my private Apache > > account ([1]). > > > > Please take a look at the "1.2.8" artifacts and vote. Please note that > > this is my first time putting together a release for Trinidad so if you > > could pay extra attention, I would be much appreciative. > > ------------------------------------------------ > > [ ] +1 for community members who have reviewed the bits > > [ ] +0 > > [ ] -1 for fatal flaws that should cause these bits not to be released, > > and why.............. > > ------------------------------------------------ > > > > Thanks, > > Scott > > > > [1] > > http://people.apache.org/~sobryan/trinidad/1.2.8<http://people.apache.org/%7Esobryan/trinidad/1.2.8> > > > > > > -- > View this message in context: > http://www.nabble.com/-VOTE--Release-of-Trinidad-1.2.8-tp17266073p17271827.html > Sent from the My Faces - Dev mailing list archive at Nabble.com. > >
