[ 
https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571191#action_12571191
 ] 

Gabrielle Crawford commented on TRINIDAD-883:
---------------------------------------------

The RI cannot remove the locking. Fix in RenderKitDecorator is to save off the 
renderkitFactory on the applicationScopeConcurrentMap in order to avoid locking 
issues from FactoryFinder.getFactory

> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
>                 Key: TRINIDAD-883
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-883
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.4-core
>            Reporter: Stevan Malesevic
>            Assignee: Gabrielle Crawford
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit()
>  tries to get a instance of  RenderKitFactory on every call. The problem is 
> that getFactory call results in locking. Since, according to documentation, 
> RenderKitFactory::getFactory returns a per-web-application instance of the 
> appropriate implementation class for the specified JavaServer Faces factory 
> class,  RenderKitDecorator.getRenderKit()  should just used cached 
> RenderKitFactory 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to