The way you made it configurable is ok, better than my solution by the way.

I was just wondering that you switch the assignee while status
'inProgress' without inform me or ask how far i am.

I'm currently looking into commons-fileupload for a solution to
successfull parse the request and just dropping the oversized files.

2006/10/7, Bernd Bohmann <[EMAIL PROTECTED]>:
Hä?

What is the difference between made it configurable or not.

The default size was 1 MB this is maybe not enough.. this is really not
nice and the upload dir should configurable, too.

A more integrated solution in JSF would be an own faces-context-factory
with a FacesContextImpl that can handle fileupload.

Regards

Bernd


Volker Weber wrote:
> Bernd, thats not nice, i was already working on this issue.
>
> Have you checked the behavior when uploading a oversized file?
> The Filter will throw an exception which is not catched and results in
> showing in the client window.
>
> I thing we need a solution where just the oversized file is wasted and
> the related fileInputcomponent don't validates, but all other inputs
> should saved, and the view
> should rerendered with appropriate facesMessage.
>
> regards
>  Volker
>
>
>
>
> 2006/10/7, [EMAIL PROTECTED] <[EMAIL PROTECTED]>:
>> Author: bommel
>> Date: Sat Oct  7 01:40:36 2006
>> New Revision: 453864
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=453864
>> Log:
>> [TOBAGO-120] Enable configuration of max filesize and uploadTempDir
>> for Fileupload
>>
>> Modified:
>>
>> 
myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataFilter.java
>>
>>
>> 
myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataRequest.java
>>
>>
>> 
myfaces/tobago/trunk/core/src/test/java/org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataRequestUnitTest.java
>>
>>
>> Modified:
>> 
myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataFilter.java
>>
>> URL:
>> 
http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataFilter.java?view=diff&rev=453864&r1=453863&r2=453864
>>
>

Reply via email to