Hi, No, I don’t think we used ICLAs for mshadow before.
Out of the 42 people who made more than 1 commit or more than 10 lines of code change to mshadow, 26 signed ICLA with Apache (and additionally one member is unfortunately deceased...). Would this be a better criteria as “the major ones”? I wasn’t part of the initial code donation or the initial PPMC group, so apologies if the questions were silly. I think the rest of the commits are manageable so that I could do a revert and rework for those commits if/when necessary. Regards, Sheng > On Jul 22, 2020, at 11:50 PM, Justin Mclean <[email protected]> wrote: > > Hi, > >> Thanks for clarifying. All contributors who made more than 10 commits to >> msahdow before are committers of MXNet, so their ICLAs should already be on >> file: tqchen, bingxu, eric.xie, sxjscience, mli, yajiedesign [1]. If you >> think this is OK, one of the mentors or I can start the notification. > > > What about the other 60 contributors? More than 10 commits is not a line I > would feel comfortable with. You need to be able to account for the IP > provenance of every line of code, just like in your initial code donation. It > would probably be best to make a list all contributors and if they have an > ICLA or not. Did the mshadow project use ICLAs? If so that may also help. > > Thanks, > Justin
