I think this is a nit and it is hard to argue which one is best, everyone has their own preference. In this case, Google C style is a simple convention that everyone can refer to, and I would suggest we just stick with that convention
Tianqi On Tue, Jan 8, 2019 at 2:44 PM Pedro Larroy <[email protected]> wrote: > Hi MXNet community > > cpplint seems to complain when the order of includes is not [own, > system, other] > > But the general best practice in C++ is [own, project, 3rd party, > system] for the reasons explained in this stackoverflow answer: ( > https://stackoverflow.com/questions/614302/c-header-order ) > > A contribution to cpplint could be made to make this configurable: > > https://github.com/cpplint/cpplint/blob/master/cpplint.py#L605 > > Thoughts? > > Pedro. >
