Agree to make incremental improvements. As long as the changes do not change the current states of memory leak, but improve the documents and demonstrate the way to use type-safe apis, I think it is fair to merge into v1.3. On Wed, Jul 11, 2018 at 4:43 PM Naveen Swamy <[email protected]> wrote: > > Qing, its great that you are working on improving the Scala Examples with > documentation and tests. > Ideally, we shouldn't have any memory leaks..it erodes trust with our > users, however I understand it can take significant time and debugging > effort to resolve them. Given that these leaks already exist, may be should > call out on the documentation that this is a known issue and we will work > on it. > IMO for this case making incremental improvements to examples makes sense. > > I would like to hear what others think. > -Naveen > > On Wed, Jul 11, 2018 at 3:47 PM, Qing Lan <[email protected]> wrote: > > > Hi all, > > > > I would like to propose the release plan for MXNet Scala examples in V1.3. > > Currently, the examples in the main repository are not maintained for a > > long time. I have spent some time to use the improved Scala API (known as > > the .api) to improve the examples with documentation to run and add CI > > tests. However, I am facing the difficulties to resolve memory leaks as > > most of the examples did not contains memory leak fixes. It crashes the CI > > because of that. We can temporarily disable the CI test for some of the > > examples and release them with 1.3 and enable them once we have a better GC > > in MXNet Scala. Here is a brief Pros and Cons for this release: > > > > Pros: > > > > * A good set of demos on how to use improved Training API > > * Examples are fixed with full documentation to help to run them > > > > Cons: > > > > * Examples contains the memory leak issues may cause problems > > > > Please kindly share your ideas in this thread and I am really appreciate > > for your help. > > > > Thanks, > > Qing > >
-- Yizhi Liu DMLC member Amazon Web Services Vancouver, Canada
