Sign up for an account on xircles.codehaus.org then you can use that account to login to jira
On Saturday, 18 January 2014, B. K. Oxley (binkley) <[email protected]> wrote: > Thanks, Anders. > > How do I log into your JIRA? Account creation indicates I need an admin. > > Cheers, > Brian > > > > On Fri, Jan 17, 2014 at 2:58 PM, Anders Hammar <[email protected]> wrote: > > Please create a JIRA ticket (with patch) as explained here: > http://mojo.codehaus.org/animal-sniffer-maven-plugin/issue-tracking.html > > Also, mixing two "fixes" isn't a good thing. You should create two > separate tickets. And then two separate patches. The tickets are used as > release notes when releasing, so mixing fixes will make it difficult for > people to see what has changed. > > /Anders > > > On Thu, Jan 16, 2014 at 11:26 PM, B. K. Oxley (binkley) < > [email protected]> wrote: > > Hi, > > I have two changes for the animal sniffer maven plugin. Apologies for > mixing them, but while fixing one the other seemed obvious. > > A. Create a "test-check" goal for checking test classes. I recently broke > another project with a commit of a test class containing a JDK7 API call; > the project should compile with JDK5. This was my motivation for looking > at the animal sniffer plugin. > > B. Update the source directory for checking to include locations other > than ${basedir}/src/*/java. When using other maven plugins, e.g. the build > helper plugin, or generated code there may be additional source roots. > > I do not know the procedure for contributing, so I append output from "svn > diff src" below. It would be helpful for me if these changes could appear > in version 1.10; for now I'm commenting out "test-check" in my project pom. > > Please do not hesitate to contact me with any questions or concerns. I am > happy to sign copyright documents, if required. > > > Regards, > --binkley > > > Index: > src/main/java/org/codehaus/mojo/animal_sniffer/maven/CheckSignatureMojo.java > =================================================================== > --- > src/main/java/org/codehaus/mojo/animal_sniffer/maven/CheckSignatureMojo.java > (revision > 19274) > +++ > src/main/java/org/codehaus/mojo/animal_sniffer/maven/CheckSignatureMojo.java > (working > copy) > @@ -25,25 +25,8 @@ > * > */ > > -import org.apache.maven.artifact.factory.ArtifactFactory; > -import org.apache.maven.artifact.repository.ArtifactRepository; > -import > org.apache.maven.artifact.resolver.AbstractArtifactResolutionException; > -import org.apache.maven.artifact.resolver.ArtifactResolver; > -import org.apache.maven.plugin.AbstractMojo; > -import org.apache.maven.plugin.MojoExecutionException; > -import org.apache.maven.plugin.MojoFailureException; > -import org.apache.maven.project.MavenProject; > -import org.codehaus.mojo.animal_sniffer.ClassFileVisitor; > -import org.codehaus.mojo.animal_sniffer.ClassListBuilder; > -import org.codehaus.mojo.animal_sniffer.SignatureChecker; > - > import java.io.File; > > -- Sent from my phone
