Inner classes are badly encoded in XML reports
----------------------------------------------

                 Key: MFINDBUGS-113
                 URL: http://jira.codehaus.org/browse/MFINDBUGS-113
             Project: Maven 2.x FindBugs Plugin
          Issue Type: Bug
            Reporter: Simon Brandhof


The sign $ of inner class names is replaced by %24 in the attribute classname 
of the node <file> : :
{code:xml}
<file classname='hudson.plugins.sonar.SonarPublisher%24DescriptorImpl'>
  <BugInstance type='EI_EXPOSE_REP' priority='Normal' category='MALICIOUS_CODE' 
message='hudson.plugins.sonar.SonarPublisher$DescriptorImpl.getInstallations() 
may expose internal representation by returning 
SonarPublisher$DescriptorImpl.installations' lineNumber='480'/>
</file>
{code}

The message is ok.

The problem comes from the class XDocsReporter.groovy, line 178 :
{code}
file(classname: URLEncoder.encode(bugClass, outputEncoding)) {
{code}  

Why is it encoded in the URL format ? I don't know Groovy. Does the class 
groovy.xml.StreamingMarkupBuilder encode itself the stream ? If yes, then the 
code would be simply :

{code}
file(classname: bugClass) {
{code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to