[
http://jira.codehaus.org/browse/MOJO-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=186450#action_186450
]
Jochen Wiedmann commented on MOJO-1357:
---------------------------------------
Couple of comments:
- Unit tests for your features would be good.
- I am not overly happy about an 18K patch. Several patch files (one per
feature) would help.
- Resolver.resolve may return null. I think that's not considered in
return tf.newTemplates( pResolver.resolve( stylesheet,
getBasedir() ) );
- Catching both a TransformerException and a TransformerConfigurationException
is redundant.
The latter can be removed.
- Using 1.5 is a little bit early. Ok, Maven 2.2 is on Java 1.5 now, but this
is still the minority out
in the field. Apart from that, I don't see to any reasons for using 1.5. Do
you?
- I do not understand this comment:
// Resolver fixes this?!
// But, it does not work anyway since its an absolute file path and
// not a systemId
//stylesheet = asAbsoluteFile( stylesheet );
Why should an absolute file path not be a system id? Any XML parser I am
aware of would
happily accept that.
> Some patches to enhance the resolver and make multi output from xsl work
> ------------------------------------------------------------------------
>
> Key: MOJO-1357
> URL: http://jira.codehaus.org/browse/MOJO-1357
> Project: Mojo
> Issue Type: Wish
> Components: xml
> Affects Versions: buildnumber-maven-plugin-1.0-beta-3
> Reporter: Peter Antman
> Assignee: Jochen Wiedmann
> Priority: Minor
> Attachments: IncludeProjectDependenciesComponentConfigurator.java,
> pra.diff
>
>
> I have made some improvements the get the plugin to work nicely with docbook
> xsl. This includes among other things:
> * Make sure resolver is set on all constructed/resolved Sources
> * Make multiple output from one xsl land in the correct output directory
> * Make transformer fail when an error happens in transform
> * Make it possible to use in multi module setup with different dependencies
> (use project dependencies)
> * Enhanced logging in the Resolver
> * Switched to 1.5 (easy to make 1.4 compatible again)
> Hope it might be useful in some way.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
