Good Morning Patrick could you upload plugin and test-harness somewhere (and let me have access).. I would really like to get this working (and close out this bug)
Many Thanks for your help (and support)! Martin Gainty ______________________________________________ Inte förändra och störa denna överföring tack Date: Mon, 30 Dec 2013 07:46:49 -0800 From: robert.patr...@oracle.com To: dev@maven.apache.org Subject: RE: Plugin phase awareness... Seems to work properly with Maven 3.0.5 anyway. See attached plugin and test project. -- Robert Patrick <robert.patr...@oracle.com> VP, FMW Platform Architecture Oracle Corporation Office: +1.940.725.0011 1148 Triple Crown Court Fax: +1.940.725.0012 Bartonville, TX 76226, USA Mobile: +1.469.556.9450 Professional Oracle WebLogic Server by Robert Patrick, Gregory Nyberg, and Philip Aston with Josh Bregman and Paul Done Book Home Page: http://www.wrox.com/ Kindle Version: http://www.amazon.com/ -----Original Message----- From: Martin Gainty [mailto:mgai...@hotmail.com] Sent: Sunday, December 29, 2013 7:25 PM To: Maven Developers List Subject: RE: Plugin phase awareness... > From: mgai...@hotmail.com > To: dev@maven.apache.org > Subject: RE: Plugin phase awareness... > Date: Sun, 29 Dec 2013 17:46:29 -0500 > > > > > > > > Date: Sun, 29 Dec 2013 15:13:12 +0000 > > Subject: Re: Plugin phase awareness... > > From: stephen.alan.conno...@gmail.com > > To: dev@maven.apache.org > > > > Are you running the mojo directly in your testing by any chance? > > > > Eg > > > > mvn short-name:goal > MG>Correct I was testing in this fashion > > > As opposed to > > > > mvn phase > MG>Thanks Stephen I will try this out MG_12_29_2013> /** * @parameter expression="${mojoExecution}" */ @Parameter(defaultValue = "${mojoExecution}") private org.apache.maven.plugin.MojoExecution execution; //supposedly mojoExecution injected here public org.apache.maven.plugin.MojoExecution getExecution() { return execution; } //accessor for execution /** * @parameter expression="${mojoExecution.lifecyclePhase}" */ @Parameter(defaultValue = "${mojoExecution.lifecyclePhase}") private String lifecyclePhase; //supposedly lifecyclePhase is injected here public org.apache.maven.model.Plugin plugin=new org.apache.maven.model.Plugin(); public String getLifecyclePhase() { //accessor for lifecyclePhase if(lifecyclePhase==null) { plugin.setGroupId("org.apache.maven.plugins"); plugin.setArtifactId("maven-compiler-plugin"); plugin.setVersion("3.1"); String goal="compile"; String executionId="executionId"; System.out.println("CompilerMojoTestCase::getLifecyclePhase goal="+goal+" executionId="+executionId); org.apache.maven.plugin.MojoExecution mojo=new org.apache.maven.plugin.MojoExecution((org.apache.maven.model.Plugin)plugin, goal, executionId ); lifecyclePhase= mojo.getLifecyclePhase(); } return lifecyclePhase; } MG_12_29_2013>public void testCompilerBasic() throws Exception { System.out.println("CompilerMojoTestCase::testCompilerBasic LINE 143 getLifeyclePhase()= "+getLifecyclePhase()); MG_12_29_2013>mvn -e -X -o process-test-classes 1> errors.lst MG_12_29_2013>CompilerMojoTestCase::getLifecyclePhase goal=compile executionId=executionId MG_12_29_2013>CompilerMojoTestCase::testCompilerBasic LINE 143 getLifeyclePhase()= null MG_12_29_2013>My thinking is that lifecyclePhase is somehow not being injected.. MG_12_29_2013>Ideas? > > > Because if the former, then the phase is null as the execution was > > not bound to a phase. > > > > I have not used this specific property before, so cannot speak to > > whether it works when bound to a phase, but if your test plugin > > execution is not bound to a phase then you would not expect to see a > > non null value > > > > On Sunday, 29 December 2013, Martin Gainty wrote: > > > > > Morning All- > > > > > > > > > > > > Even after downloading maven-core 3.1.1 source and re-compiling to > > > new maven-core-3.1.1.jar distro and forcing maven-core-3.1.1 > > > dependency into maven-surefire-plugin > > > > > > > > > I could not get ${mojoExecution.lifecyclePhase} to display > > > anything other than null > > > > > > > > > https://jira.codehaus.org/browse/MNG-5555 > > > > > > > > > > > > Ideas? > > > > > > Martin -- > > > ______________________________________________ > > > > > > > > > Inte förändra och störa denna överföring > > > > > > > > > > > > > > > > > > > > > > > > From: mgai...@hotmail.com <javascript:;> > > > To: dev@maven.apache.org <javascript:;> > > > Subject: RE: Plugin phase awareness... > > > Date: Wed, 25 Dec 2013 22:40:07 -0500 > > > > > > > > > > > > > > > Wasted an enormous amount of time chasing the exact location of > > > .git file.. i guess its a good thing it was Christmas > > > > > > Thanks Jason! > > > Martin Gainty > > > ______________________________________________ > > > > > > > > > > > > > > > > > > > From: jpye...@pdinc.us > > > > To: dev@maven.apache.org > > > > Subject: RE: Plugin phase awareness... > > > > Date: Wed, 25 Dec 2013 10:52:34 -0500 > > > > > > > > > -----Original Message----- > > > > > From: Martin Gainty > > > > > Sent: Wednesday, December 25, 2013 10:40 > > > > > > > > > > bash>git clone > > > > > bash>https://github.com/apache/maven/blob/maven-3.1.1/maven-co > > > > > bash>re src > > > > > Cloning into 'src'... > > > > > fatal: repository > > > > > 'https://github.com/apache/maven/blob/maven-3.1.1/maven-core/' > > > > > not found > > > > > > > > It is not like subversion, git clone > > > > https://github.com/apache/maven.git > > > > > > > > The git operation will have to happen from the root of the > > > > repository, > > > and git > > > > hub does not auto redirect git clones to the proper url from the > > > > repo > > > browser > > > > urls. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Tue, 24 Dec 2013 18:51:59 -0500 > > > > > > From: i...@ifedorenko.com > > > > > > To: dev@maven.apache.org > > > > > > Subject: Re: Plugin phase awareness... > > > > > > > > > > > > > > > > > https://github.com/apache/maven/blob/maven-3.1.1/maven-core/sr > > > > > c/main/j > > > > > > ava/org/apache/maven/plugin/MojoExecution.java#L160 > > > > > > > > > > > > > > > > > > ... and, like I said, the example I pasted elsewhere in this > > > > > > thread does work in maven 3.0.5 and 3.1.1. > > > > > > > > > > > > -- > > > > > > Regards, > > > > > > Igor > > > > > > > > > > > > On 12/24/2013, 18:01, Martin Gainty wrote: > > > > > > > not found in 3.1.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > ${user.home}\org\apache\maven\maven-core\3.1.1\jar>javap > > > > > > > .\or g\apache\maven\plugin\MojoExecution | grep > > > > > > > lifecyclePhase > > > > > > > > > > > > > > > > > > > > > Warning: Binary file > > > > > > > .\org\apache\maven\plugin\MojoExecution > > > > > > > contains org.apache.maven.plugin.MojoExecution > > > > > > > > > > > > > > > > > > > > > I have 3.1.1 fully operational but I cannt locate the > > > > > lifecyclePhase > > > > > > > in MojoExecution > > > > > > > > > > > > > > I *thought* 3.1.1 was latest...does anyone know where the > > > > > lifecyclePhase attribute is located? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > Martin > > > > > > > > > > > > > > ______________________________________________ > > > > > > > God jul till alla och > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >> From: mgai...@hotmail.com > > > > > > >> To: dev@maven.apache.org > > > > > > >> Subject: RE: Plugin phase awareness... > > > > > > >> Date: Tue, 24 Dec 2013 08:01:01 -0500 > > > > > > >> > > > > > > >> mvn version 3.0.2 > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> public class CompilerMojo extends AbstractCompilerMojo > > > > > > >> > > > > > > >> { > > > > > > >> > > > > > > >> /** > > > > > > >> * @parameter expression="${mojoExecution}" > > > > > > >> */ > > > > > > >> @Pa > > > > > > > > -- > > Sent from my phone > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
