When Sisu with this fix is released I'll cut a 3.1.1. On Jul 18, 2013, at 5:27 AM, Stuart McCulloch <[email protected]> wrote:
> On 18 Jul 2013, at 12:12, sebb wrote: > >> On 18 July 2013 09:36, Stuart McCulloch <[email protected]> wrote: >>> On 18 Jul 2013, at 05:41, Brett Porter <[email protected]> wrote: >>> >>>> Hi, >>>> >>>> I've got a regression here using the Swagger Maven Plugin [1] that looks >>>> different to the Aether one. Before I go poking around further, I was >>>> wondering if anyone can tell me if it's a regression on the Maven (and >>>> dependencies) end, or something expected to be updated in the plugin? >>> >>> The converter code (part of the plexus adapter layer) was clean-roomed when >>> it moved to eclipse and this particular legacy constructor was missed. >>> >>> I'll fix this and stage a container update - note that the call to register >>> the realm converter isn't strictly necessary and could also be removed from >>> the plugin. >> >> Might be worth flagging the legacy constructor as deprecated? >> With Javadoc comment to say what to do instead? > > That's good for people reading (and compiling) against the latest API but > doesn't inform people building against the old API - also some of the binary > compatibility wrt. the old and new ClassRealm API is managed with reflection, > so anyone upgrading builds to use the 3.x API would have to use the > org.codehaus.plexus.classworlds.realm.ClassRealm type since the old > org.codehaus.classworlds.ClassRealm type was removed post 2.x > > So it might be better to also log a deprecated message at runtime (debug?) > >>> -- >>> Cheers, Stuart >>> >>>> [ERROR] Failed to execute goal >>>> com.github.kongchen:swagger-maven-plugin:1.1.1:generate (default) on >>>> project maestro-webapp: An API incompatibility was encountered during >>>> configuration of mojo >>>> com.github.kongchen:swagger-maven-plugin:1.1.1:generate: >>>> java.lang.NoSuchMethodError: >>>> org.codehaus.plexus.component.configurator.converters.special.ClassRealmConverter.<init>(Lorg/codehaus/classworlds/ClassRealm;)V >>>> [ERROR] ----------------------------------------------------- >>>> [ERROR] realm = plugin>com.github.kongchen:swagger-maven-plugin:1.1.1 >>>> [ERROR] strategy = >>>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy >>>> [ERROR] urls[0] = >>>> file:/Users/brett/.m2/repository/com/github/kongchen/swagger-maven-plugin/1.1.1/swagger-maven-plugin-1.1.1.jar >>>> [ERROR] urls[1] = >>>> file:/Users/brett/.m2/repository/org/codehaus/plexus/plexus-utils/1.5.15/plexus-utils-1.5.15.jar >>>> >>>> It seems to be the same error that was fixed in an 3.0 RC [2]. >>>> >>>> Anyone seen this before? >>>> >>>> - Brett >>>> >>>> [1] https://github.com/kongchen/swagger-maven-plugin >>>> [2] http://jira.codehaus.org/browse/MNG-4832 >>>> >>>> -- >>>> Brett Porter >>>> [email protected] >>>> http://brettporter.wordpress.com/ >>>> http://au.linkedin.com/in/brettporter >>>> http://twitter.com/brettporter >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl --------------------------------------------------------- Simplex sigillum veri. (Simplicity is the seal of truth.)
