No problems, I didn't add a negative vote as I didn't look into what they were doing but merely just mentioning what I saw.
/Anders On Wed, Jan 30, 2013 at 10:20 AM, Olivier Lamy <[email protected]> wrote: > That's just properties already defined in parent. > Just redundancy sure maybe that could improve performance with > reducing the number of transfered bytes when downloaded the pom :-) > Perso I won't consider this as blocker as we are talking about a pom > release so any sub project can override values. > > 2013/1/30 Anders Hammar <[email protected]>: > > I see two of these comments: > > > > <!-- TODO remove when upgrading parent to 23 --> > > > > And we're using maven-parent v23. > > > > /Anders > > > > > > On Wed, Jan 30, 2013 at 6:38 AM, Kristian Rosenvold < > > [email protected]> wrote: > > > >> +1 > >> > >> Den 30. jan. 2013 kl. 00:41 skrev Olivier Lamy <[email protected]>: > >> > >> > Hi, > >> > I'd like to release Plugins parent 24 and Shared parent 19. > >> > Staging repository: > >> > https://repository.apache.org/content/repositories/maven-172/ > >> > > >> > Diffs: > >> > > >> > * Plugins parent 24: > >> > > >> > http://svn.apache.org/viewvc/maven/plugins/tags/maven-plugins-24/pom.xml?r1=HEAD&r2=1371605&diff_format=h > >> > > >> > * Shared parent 19: > >> > > >> > http://svn.apache.org/viewvc/maven/shared/tags/maven-shared-components-19/pom.xml?r1=HEAD&r2=1371614&diff_format=h > >> > > >> > Vote open for 72H. > >> > > >> > [+1] > >> > [0] > >> > [-1] > >> > > >> > > >> > -- > >> > Olivier Lamy > >> > Talend: http://coders.talend.com > >> > http://twitter.com/olamy | http://linkedin.com/in/olamy > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: [email protected] > >> > For additional commands, e-mail: [email protected] > >> > > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
