2011/11/22 Simone Tripodi <[email protected]>:
> Hi all guys!
>
> @Olivier: I just have, as users, few
> observations/suggestions/something I would like to have:
>
> 1) I noticed in the cli you have to express the serverUrl, my 2 cents
> question is: wouldn't be more canonical retrieve that info in the pom,
> under the <issueManagement> element?
>
> pom.xml
> {{{
> <issueManagement>
> <system>JIRA</system>
> <url>https://jira.codehaus.org/browse/MSKINS/</url>
> </issueManagement>
> }}}
Yup it does.
If all parameter are here you can use -B and you won't have any
questions from maven :-)
>
> cli
> {{{
> A typical cli is: mvn patch-tracker:create -e -X
> -Dpatch.summary="foo summary"
> -Dpatch.user=uid -Dpatch.password=pwd
> }}}
>
> As a side note, I would suggest to replace the `patch.` prefix with
> something closer to issueManagement keyword, since when creating an
> issue the user is not really pushing a patch :P
>
The issueMngt is used only in case of jira.
In the case of reviewboard or whatever something else, it won't be the same.
That's why I prefer to use the prefix patch as the goal is really to
send a patch to a "patch tracker" (agree the first impl works with an
issue tracker :-))
> You could support both anyway, that approaches are not mutual exclusive :P
>
> 2) For updating issues you could use, like the changes-plugin already
> does, an issue link template and users should just to express the
> issue id like you already did
>
> pom.xml
> {{{
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>patch-tracker</artifactId>
> <version>X.X</version>
> <configuration>
> <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>
> </configuration>
> </plugin>
> }}}
>
> cli
> {{{
> mvn patch-tracker:update -e -Dscm.providerType=git
> -Dpatch.description="update of the issue with an other patch"
> -Dpatch.issueId=BOH-5203 -B
> }}}
why not
>
> 3) The SCM provider could be discovered from the <scm> section in the pom XML
That's the case :-) (see my first mail in this thread :P )
But you can override if you use git svn
>
> pom.xml
> {{{
> <scm>
> <connection>scm:svn:http://svn.apache.org/repos/asf/...</connection>
>
> <developerConnection>scm:svn:https://svn.apache.org/repos/asf/...</developerConnection>
> <url>http://svn.apache.org/viewvc/...</url>
> </scm>
> }}}
>
> since the schema is scm:(providerType):URL
>
> I'm not (yet, hopefully I'll be able to provide more help, before or
> after...) deep inside Maven internals/plugin development, anyway after
> all these consideration I would tend to express my opinion that this
> new plugin could naturally fit in the changes plugin, that would track
> the whole change lifecycle: open-provide patch-resolve-report
>
> These are just my 2cents opinions :)
>
> @Dennis: thanks a lot for your invitation, as soon as Fluido will be
> released - and I get out from my status of n00b :P - I will start
> providing my feedbacks :)
>
> All the best, have a nice day!!!
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Tue, Nov 22, 2011 at 7:25 AM, Dennis Lundberg
> <[email protected]> wrote:
>> Hi Ralph
>>
>> I haven't gotten that far yet. There is one obstacle left to fix, before an
>> api can be extracted, and that is full use of Java 5 generics. That in turn
>> is currently blocked by an issue in Modello, that prevents upgrading to a
>> version of Modello that can generate Java 5 code.
>>
>> Extracting an api is something I've wanted to do for some time. Looking
>> ahead I will have time to work on it soon. As always with api design
>> though, it help to be more than one person working on it.
>>
>>
>> On Monday, November 21, 2011, Ralph Goers <[email protected]>
>> wrote:
>>> Dennis - have you by chance modified the changes plugin so that there is
>> a jar with most of the logic and the plugin? I recently wanted to create a
>> new plugin that used logic from the changes plugin but couldn't see how to
>> do it.
>>>
>>> Ralph
>>>
>>> On Nov 21, 2011, at 1:01 PM, Dennis Lundberg wrote:
>>>
>>>> On 2011-11-21 21:55, Simone Tripodi wrote:
>>>>> Salut Olivier!
>>>>> in one word: GREAT :)
>>>>>
>>>>> I just have 2 minor suggestions:
>>>>>
>>>>> * name attachments as `*.patch`
>>>>> * I didn't have a look at the sourcecode already, but please design
>>>>> the plugin to easily plug other issue tracker (not like the changes
>>>>> plugin)
>>>>
>>>> I've worked quite a lot on the Changes Plugin, trying to move it towards
>>>> using a high-level issue tracker API. It's far from finished, but if you
>>>> are interested, we might put our minds together and sketch something up.
>>>>
>>>>> well done, impressive work!
>>>>> Simo
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi
>>>>> http://www.99soft.org/
>>>>>
>>>>>
>>>>>
>>>>> On Mon, Nov 21, 2011 at 9:33 PM, Olivier Lamy <[email protected]> wrote:
>>>>>> Hello,
>>>>>>
>>>>>> FYI, I have created a new plugin called maven-patch-tracker-plugin in
>> sandbox.
>>>>>>
>>>>>> Basically, this plugin will generate a diff using the scm provider
>>>>>> configured in your pom (note if the pom says svn but you use git svn,
>>>>>> you can use -Dscm.providerType=git).
>>>>>> Then will create an issue in your configured issue tracker (currently
>>>>>> only jira is supported) and attach the patch.
>>>>>>
>>>>>> A typical cli is: mvn patch-tracker:create -e -X
>>>>>> -Dpatch.summary="foo summary"
>>>>>> -Dpatch.serverUrl=http://localhost:8080/browse/MNG -B
>>>>>> -Dpatch.user=uid -Dpatch.password=pwd
>>>>>>
>>>>>> Note you can add an entry in your settings and use it for authz with
>>>>>> -Dpatch.serverId=serverIdFromYourSettings (and you can remove
>>>>>> -Dpatch.user -Dpatch.pasword from your cli).
>>>>>>
>>>>>> The server url can come from the pom. (issueManagement/url).
>>>>>> Urls with component id are supported too:
>>>>>> https://jira.codehaus.org/browse/MSHARED/component/15255 (and issue is
>>>>>> created in MSHARED and attach to the component with 15255)
>>>>>>
>>>>>> Note: there is a prompter use to setup values, BTW you can use -B and
>>>>>> nothing will be asked if your configuration is correct.
>>>>>>
>>>>>> An other goal is to update an issue with an other patch:
>>>>>> mvn patch-tracker:update -e -Dscm.providerType=git
>>>>>> -Dpatch.description="update of the issue with an other patch"
>>>>>> -Dpatch.patchId=MNG-5203 -B
>>>>>>
>>>>>> The result is something like: https://jira.codehaus.org/browse/MNG-5203
>>>>>>
>>>>>> Let me know if you see any other features (I think I will add support
>>>>>> of loading patch in review board).
>>>>>>
>>>>>> Have fun!
>>>>>> --
>>>>>> Olivier Lamy
>>>>>> Talend: http://coders.talend.com
>>>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: [email protected]
>>>>>> For additional commands, e-mail: [email protected]
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [email protected]<
>>
>> --
>> Dennis Lundberg
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
