Because wagons are per-lookup beans and not singleton. So to enable this feature, the pooled connection manager must a static field or available in a singleton component (to be shared between all wagon http instances) and initialised only once time. That's why the flag cannot be configurable tru a normal plexus configuration mechanism. So a static code block will check the flag and initialise or desactivate (depending on what default we prefer) the ThreadSafeClientConnManager instance.
Btw as I'm not a big fan of sysprops :-), I will check more if possible to not use it (using more an other singleton component rather than the static block code) But maven is a cli tool so options must be available tru cli (rather than complicated xml in ~/.m2/settings.xml :-) ) 2011/8/24 nicolas de loof <nicolas.del...@gmail.com>: > +1 to set this as default > why use system properties to set this flag and not use a per-instance > configuration ? > > 2011/8/24 Olivier Lamy <ol...@apache.org> > >> Hello Folks, >> I have just loaded an issue [1] regarding an improvement for wagon >> http (the wagon http which use asf httpclient). >> This small improvement will simply add a connection pooling mechanism >> to avoid http(s) connection for artifacts requests. >> >> My first idea was to not enable it by default but using a sysprops to >> enable it : -Dmaven.wagon.http.connectionManager.multihreaded=true . >> But IMHO this could be activate by default (with a flag to desactivate it). >> >> WDYT ? >> >> Thanks, >> -- >> Olivier Lamy >> Talend : http://talend.com >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> [1] : https://jira.codehaus.org/browse/WAGON-348 >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > -- Olivier Lamy Talend : http://talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
