I found the bug in the modello plugin that was breaking /any/ build using modello in multi-modules; and I'm fairly sure the same kind of issue will be found elsewhere:

Quite simply the mojo's use plexus components that are singletons but the mojos themselves contain per-request mutable state (http://jira.codehaus.org/browse/MODELLO-239).

Since we're only a very short time away from beta-1 I just wanted to know what you think should be done:

A) Treat this as a documentation problem and do maybe just update some mojo guidelines regarding singleton usage, maybe keep a list of known good versions. B) Add some kind of "isThreadSafe" attribute to the mojo metadata that could be used to assert if the mojo can be run concurrently without warning, i.e.:
if ( isParallel() && !isThreadSafe( mojo))
{
logger.warn("Mojo " + mojo + " is not known to be thread safe and may have issues running concurrently");
}
C) Something else  ?


Thoughts ? If B, how should it be done ?

Kristian






---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to