Brian,

You can see what happens just by running:
mvn -Prelease package
then look at whats in the jars.

On Wednesday 14 March 2007 20:16, Brian E. Fox wrote:
> So I can remove this code from my pom then:

Correct, shouldn't be needed.

> <resources>
>                       <!-- Include the apache process LICENSE and
> NOTICE files.-->
>                       <!--uncomment for release. Commented out for now
> to enable eclipse-plugin to work-->
>                       <resource>
>                               <targetPath>META-INF</targetPath>
>                               <filtering>false</filtering>
>                               <directory>${basedir}</directory>
>                               <includes>
>                                       <include>LICENSE</include>
>                                       <include>NOTICE</include>
>                               </includes>
>                       </resource>
>
>
> But is this still needed?

Nope.  Shouldn't be.

>
>                       <!-- Include super-pom defined main/resources
>                       Removing this section will break the build.
>                       Since we have defined a new build/resources
>                       section for the Apache process LICENSE and
> NOTICE
>                       files, this original default section is now
>                       required. -->
>                       <resource>
>
> <directory>${basedir}/src/main/resources</directory>
>                       </resource>

Dan



>
>
>
> -----Original Message-----
> From: Daniel Kulp [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, March 14, 2007 7:46 PM
> To: dev@maven.apache.org
> Subject: Re: [VOTE] Release maven and plugins parent pom
>
> On Wednesday 14 March 2007 18:59, Brian E. Fox wrote:
> > Is there a way to include notice and license files in the jars by
> > default?
>
> Well, we could pull the remote-resources plugin out of the release
> profile and put it right in the build/plugins section of the pom to
> force it to always run.   However, there is a bug in it (just fixed
> today) that causes issues with SNAPSHOT dependencies.   Thus, that
> won't
>
> work until we release a new version of the remote-resources.
>
> Right now, the NOTICE and LICENSE files are injected in when run with
> the
> release profile only.   That's actually one reason we didn't discover
> the SNAPSHOT issue since the releases, by definition, don't contain
> snapshots.
>
> Dan
>
> > -----Original Message-----
> > From: Daniel Kulp [mailto:[EMAIL PROTECTED]
> > Sent: Wednesday, March 14, 2007 4:15 PM
> > To: dev@maven.apache.org
> > Subject: Re: [VOTE] Release maven and plugins parent pom
> >
> > On Wednesday 14 March 2007 16:05, Carlos Sanchez wrote:
> > > so we use the latest apache parent
> >
> > If we do, we should update to the latest gpg and remote resource
> > things as well.   Specifically gpg so we don't have to have
> > passphrases burned into our settings.xml.

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
[EMAIL PROTECTED]
http://www.dankulp.com/blog

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to