Hi Jason,
On Feb 16, 2007, at 5:27 AM, Jason van Zyl wrote:
On 16 Feb 07, at 1:12 AM 16 Feb 07, Eric Brown wrote:
My project's decided to continue using maven and patch it as
necessary to fix bugs in maven that we're no longer willing to
live with. I tried for an hour or two to get my project to build
under 2.1, but gave up and figured it was under too much active
development anyway. What is the time frame for 2.1 anyway? (3-
months, 6-months, 2-years?)
It has actually been working just fine other then a problem
introduced a few days ago which I haven't fixed yet. Wagon
extensions don't work but other then that several of us have been
using it and it's being used in production at a client of mine and
is also working fine there.
Oh. I probably hit that. I only tried on Tuesday or Wednesday. And it
seemed like some issue downloading something... If there's an issue I
can watch to know when to try again, let me know.
But if the focus is on 2.0.6 for a while, I'm still not precisely
sure which version to work with. It is not just 5 or 6 maven issues,
I've got a few plugins whose bugs screw us up too... that I need to
work on. And I've only got so much time (unfortunately)...
But I'm noticing that several of the bugs I have to patch in 2.0.5
are actually scheduled for 2.1 and some discuss architectural
issues of maven that I'm not quite familiar with yet. Thus my
question...
These are the bugs I'm in the process of patching (on my project's
fork of 2.0.5):
MNG-1994 Execution order of child plugins is arbitrary if
inheritance is involved. (Somebody should close this. It is fixed
in 2.0.5.)
Someone just mentioned that this wasn't fixed on the list
yesterday, if there is no test project then it's not confirmed.
I see a message on 2/15, but it refers to MNG-2784 which I think is a
different issue. (Though I suspect that the patch in MNG-1412 might
fix it.) Maybe it is a different message you're referring to...
If there is a person reporting MNG-1994 is still broken, they should
write a test. If I do discover in my own projects that it is still
broken, however, I will eat the words I put in the comment about it
being fixed in r425921 and immediately write a test. :)
(Maybe making it brain-dead simple for people on maven-users to write
tests would help?)
MNG-1412 Dependency sorting in classpath. I updated the patch for
this already.
Does it have tests?
Are there architecture documents to describe what is going on in the
maven-project, maven-artifact and maven-artifact-manager components?
Or even a few more javadocs and/or package level documentation? I
know we're all hard-up for time to write code, write docs, etc for
the projects we love to use, but while it is fairly easy to see what
individual classes are doing, the big picture is hard to see. And
this bug involves passing a lot of stuff around inside components and
between them. I'm struggling to understand sometimes...
The patch in MNG-1412 simply converts HashMap to LinkedHashMap and
HashSet to LinkedHashSet in a few places where it seemed ordering
made sense but was being trashed. I actually think it does more than
it needs to do to fix this specific issue.
I'll look toward writing tests... but I'd rather work initially
toward fixing the bugs in my fork (and submitting patches) instead of
writing tests and waiting for someone else to fix the issues on their
schedule. Almost 1-year between 2.0.4 and 2.0.5 has created a trust
issue on my team that has its own set of work to do. I'll try to
write tests too time permitting, but more developer-level
documentation (especially architecture level) from the maven team
would be wonderful too. If it already exists, point me toward it...
BTW, I don't mean to be too harsh on maven. I realize it is open
source. We're sticking with it despite seriously considering
migrating to ant or gant.
Cheers,
Eric
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
