Good day, Thank you for your review. I've now applied them and submitted the patch to http://jira.codehaus.org/browse/MANTRUN-55
Here is the changes within the patch: In usage.html - maven.dependency.classpath (Reported by Vincent Siveton) - Review <<<inheritRefs>> (Reported by Vincent Siveton) - it seems that there is bug here (from what i can dig up in the maven user's mailing list) such that referencing maven.xxx.classpath's within the build.xml does not work. thus, i changed the example to a workaround (assigning the maven.xxx.classpath's value to an ant property). Furthermore, this page may not be needed in the future once Vincent Siventon's submits his example of using external build.xml - changed "maven-dependencies-plugin" to "maven-dependency-plugin" In FAQ.html - "Maven for Ant Users" is for Maven1 and it's link is wrong (Reported by Vincent Siventon) - thus, i removed this link Thanks a bunch, Franz On 8/1/06, Vincent Siveton <[EMAIL PROTECTED]> wrote:
Hi, My comments: faq.html "Maven for Ant Users" link is for maven1 and should be: http://maven.apache.org/maven-1.x/start/maven-for-ant-users.html classpaths.html maven.dependency.classpath is deprecated classpath, thus I would remove it. Review <<<inheritRefs>> General comment: I would create a new example: Using external build.xml. This page should be a link in the index.html. Cheers, Vincent 2006/8/1, Allan Ramirez <[EMAIL PROTECTED]>: > maven-antrun-plugin documentation is now ready for review. > Staging site can be found here: > > http://people.apache.org/~aramirez/maven-antrun-plugin/ > > jira issue: > http://jira.codehaus.org/browse/MANTRUN-55 > > Thank you very much Franz See for your great work here. > > Cheers, > allan > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
