Hi Allan,

Other comments:

index.html
(~/.m2/repository) => italic

usage.html
install:install => italic

FAQ
add a link to the maven-deploy-plugin.

Good work. Thanks.

Vincent

2006/7/18, Allan Ramirez <[EMAIL PROTECTED]>:
By the way, the staging site can be found here
http://people.apache.org/~aramirez/maven-install-plugin/

allan

Allan Ramirez wrote:
> Ready for another review.
>
> Thanks,
> allan
>
> Dennis Lundberg wrote:
>> Allan Ramirez wrote:
>>> Hi everyone,
>>>
>>> Just updated the docs of the install plugin. I hope you dont mind if
>>> you take a look and give me some feedback about it. Thanks
>>>
>>> Cheers,
>>> allan
>>
>> Here are my comments:
>>
>> site.xml
>> - Missing the "Goals" link in the overview section.
>>
>> **/*.html
>> - Remove the text "Maven 2 Install Plugin" from the titles. The title
>> is picked up from the project name in site.xml
>> - In the example documents, the title and heading are not equal.
>>
>> index.html
>> - Change the title to "Introduction"
>>
>> usage.html
>> - "install:install goal doesnt" -> "the install:install goal doesn't"
>> - "overriden" -> "overridden"
>> - "Maven assumes the file is the main artifact for the project."
>>   Is this the same as packaging then?
>>
>> faq.html
>> - It's empty...
>>
>> examples/update-release-info.html
>> - "Updating the release information changes the project's
>> maven-metadata.xml in the local repository, forcing the current
>> installed version as the latest release version."
>> I'm sorry, but I don't understand what this means :(
>>
>> install-mojo.html
>> - createChecksum param: "Flag whether" -> "Whether"
>> - updateReleaseInfo param: No default value? It's a boolean.
>>
>> install-file-mojo.html
>> - All parameters but "file" are optional. Well that's not really
>> true. This problem might occur in other plugins as well. IIUC you
>> have to use *either* pomFile *or* groupId/artifactId/version. How do
>> we document that?
>> - generatePom param: No default value? It's a boolean.
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to