This change is only to run the duplicate code check, so it won't break
stuff (hopefully).
This is the first small step in that gradual direction you're talking about.
On 6/24/06, Brett Porter <[EMAIL PROTECTED]> wrote:
People don't necessarily even build outside of the IDE before committing
so it may not matter :)
We should ideally have an immediate integration build notification (or
block commit on it!), but I do see your point.
The minimum I'd settle for here is a profile that is enabled by default
and can be disabled, but I'm still not sure I like that. I like builds
to be fast generally, and I like being disciplined about running the
appropriate extra tests before committing and am prepared to get
publicly slapped by CI when I don't.
Aside from this, the thing I don't like about the current changes is
that the first innocent victim that updates to the new parent POM for
whatever reason will toast the entire Maven build. We need to take baby
steps. Getting it in with just warnings or lower settings is a good
first step.
I applaud your efforts on this, I really do. I'd like to see it go
further with cobertura coverage and clirr api checks.
I think we just need to be a bit more gradual in its introduction IMO...
- Brett
On 23/06/2006 9:05 PM, Carlos Sanchez wrote:
> i think it's something that while you are working on it is easy to
> fix, but if you receive the notification after some time it's more
> annoying, opening again the file, fix it, submit again, see if it
> fails...
>
> I think it's like test coverage, if you don't have enough you can't
> leave the sandbox, and once you leave it you are required to keep the
> quality of the work.
>
> I agree that there may be exceptions when it needs to be skipped for a
> good reason, but I see that as exceptions more than the rule.
>
> It's like the repository, as there are no policies enforced
> automatically, you can deploy and then chase the people, which slows
> down the work of other people.
>
> And right now i just added duplication report, thinking that it's a no
> no to include duplicated lines. In the future I'd like to add
> checkstyle and PMD.
>
> my 2 cents
>
--
Brett Porter <[EMAIL PROTECTED]>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
