Hey Lukas, No problem, I just though that it was a good time to release. We will discuss on IRC, I'll try to connect later today.
Regarding your questions: * You're right, will fix this one * Regarding the manifest creation, we have the same kind of issues in M2 (manifests created by M2 are not compliant with the spec). I had this problem on my TODO list but I don't have much time left this month. Do you have already a clear view on this problem? If so, I think it would make sense to clarify and synchronize this with M2 codebase. Thanks, Stéphane On 5/9/06, Lukas Theussl <[EMAIL PROTECTED]> wrote:
Sorry to spoil the party but it's -1 from me for now. Could you clarify/comment on the following points: * Why did MPWAR-52 get fixed but not MPWAR-49? It's basically the same requirement (and MPWAR-34 is a dupe btw). * There are a number of issues open concerning the manifest creation (MPWAR-21, MPWAR-40, MPWAR-43, MPWAR-47), some have patches attached, some have been voted for. I have fixed similar issues in the jar plugin for its last release (MPJAR-15, MPJAR-19, MPJAR-36, MPJAR-39, MPJAR-49), I think this should be done in war accordingly. * Finally, we forgot to put back the war:validate goal from the deprecated j2ee plugin. I don't know if this is really necessary, we could do that later. Please check the docs at least to see if it's interesting: http://maven.apache.org/maven-1.x/plugins/j2ee/goals.html#j2ee:validate-war The second point is the one I am concerned about, I think it's worth to clean that up (for consistency with jar, especially since a lot of stuff can just be copied from there). This would also justify a new version 1.7 IMO. Cheers, -Lukas Stephane Nicoll wrote: > Hi, > > I'd like to call a vote to release the 1.6.2 (1.7?) version of the war > plugin for m1. There is a few issues left but I think it's a good time to > cut a release. > > the staging site is available at > http://people.apache.org/~ltheussl/maven-stage-site/maven-1.x/plugins/war/ <http://people.apache.org/%7Esnicoll/maven-2/ear/> > > > We've fixed 5 issues and added a few features for this release, notably: > > * [MPWAR-37] Property expansion while copying resources > * [MEAR-52] Configurable overwrite of the web.xml > > To get a list of all issues resolved, see: > http://jira.codehaus.org/browse/MPWAR?report=com.atlassian.jira.plugin.system.project:roadmap-panel < http://jira.codehaus.org/browse/MEAR?report=com.atlassian.jira.plugin.system.project:roadmap-panel > > > > The vote is open for 72 hours. > > Here's my +1 > > Thanks, > Stéphane > > > -- > .::You're welcome ::. > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- .::You're welcome ::.
