I didn't put a deleteOnExit for ease of debugging when a test failure/error occurred.

I found it alright since the file is created in target folder anyway and will be deleted with clean.

^_^


dan tran wrote:
in that case, deleteOnExit() should be fine. No need to do a forced delete.

-D


On 5/8/06, Brett Porter <[EMAIL PROTECTED]> wrote:

The Maven instance is forked in continuum (and the latest surefire forks
the jvm by default too).

delete() is fine, but deleteOnExit is a good extra precaution as I tihnk
it guarantees the file handle won't be in use then.

- Brett

dan tran wrote:
> deleteOnExit may not happen if it driven by Continuum, ie JVM never exit
>
> -D
>
>
> On 5/8/06, Brett Porter <[EMAIL PROTECTED]> wrote:
>>
>> should it be .deleteOnExit() ?
>>
>> dan tran wrote:
>> > I think we need to force a delete of temp file in finally block to
>> prevent
>> > file leaking
>> >
>> > File tempRootFile = File.createTempFile( source.getName() + ".", "",
>> > tempRoot );
>> > in AbstractAssemblyMojo.java
>> >
>> >
>> > WDYT?
>> >
>> > -D
>> >
>> >
>> > On 5/8/06, Brett Porter <[EMAIL PROTECTED]> wrote:
>> >>
>> >> dan tran wrote:
>> >> > Please deploy a snapshot.
>> >> >
>> >> 2.1-20060509.035708-10
>> >>
>> >>
---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> >> For additional commands, e-mail: [EMAIL PROTECTED]
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to