Hi Devs,

while implementing in Checkstyle an IDE-agnostic configuration using 
EditorConfig, I noticed inconsistencies in line endings compared to our 
intended setup.

Initially, I assumed this was due to a local .git setting related to how line 
endings are committed. However, as we know, managing line endings across 
different operating systems in Git can be tricky—making consistent 
configuration especially important.

Romani suggested addressing this within the Apache Maven Wrapper project. 
However, I’m not sure this is the most appropriate place, as it may be more of 
a local development or project-specific concern.

Although setting insert_final_newline = true in EditorConfig is a widely 
recommended best practice, its implementation can be opinionated. For instance, 
CRLF on Windows versus LF on Linux may lead to inconsistencies if not handled 
explicitly. Some contributors might also prefer different setups based on 
valid, project-specific reasons.

Here are a few relevant references:

PR #16574 <https://github.com/checkstyle/checkstyle/pull/16574>
PR #17144 <https://github.com/checkstyle/checkstyle/pull/17144>
Stack Overflow discussion on line endings 
<https://stackoverflow.com/questions/10418975/how-to-change-line-ending-settings>
Guide on normalizing line endings in Git 
<https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/>
My questions are:

Is the Apache Maven Wrapper the appropriate place to enforce consistent line 
endings?

If so, is there a clean and safe way to implement this without introducing 
unintended side effects?

Looking forward to your input—thanks!

Best regards,
Vincent

Reply via email to