Le mardi 14 janvier 2025, 14:29:29 CET Sandra Parsick a écrit : > > I'm fine with that. I have to think about the testing because I cannot use > > the original Jira project because a test run would trigger new events in > > the original PR. This would be a waste. > > Coming back to the PR reference topic. > > > This feature should be tested. But I shouldn't use the original Jira > project like I'm doing now because adding a PR reference is triggering > events in the PR. yes, I did not think at the consequence of testing on actual referenced PRs
> > To avoid lots of spam mails during testing, I think, I should test it > with a dummy Jira project. this will also impact in the future any test for data migration, that will have to avoid creating the testing noise: dummy Jira project can be useful for "unit test" of this feature, but we'll need to be careful once the feature is implemented > > My idea is > > - creating a test Jira project with issues that have links to GitHub PR > in the same style as we have in the original Maven Jira issue. > - creating a GitHub repository that has the linked PR. > - test the migration tool against the test Jira project > > What do you think? looks reasonable > > If you think it is a good idea, is it possible to create such a test > Jira project in the Apache Jira instance? ah, good ask, but not easy... what about using existing empty Jira project that you discovered? https://issues.apache.org/jira/projects/MMETRIC Regards, Hervé > > > - > Sandra > > > > > Am 14.01.25 um 10:55 schrieb Slawomir Jaranowski: > > > On Tue, 14 Jan 2025 at 09:52, Sandra Parsick <spars...@web.de.invalid> > > wrote: > > >> > >> > >>> > >>> > >>> I would like to move it to labels. > >>> We can use a stale action to close inactive issues, pr. > >> > >> > >> > >> I found the following milestone in MCLEAN, MJLINK, ARCHETYPE with label > >> characteristics (and I give the suggestion, if it was possible for me, > >> how to map): > >> > >> > >> > >> next-release* -> ? (I have no idea) > > > > can stay as is - probably will be one next milestone > > > > > >> waiting-for-feedback -> waiting for-feedback (new label) > > > > new label - I will add > > > > > >> backlog -> delete this milestone and no mapping > > > > drop - no mapping > > > > > >> more-investigation -> more-investigation (new label) > >> > >> or delete this milestone and no mapping > > > > to label - help wanted > > > > > >> > >> > >> What do you think? > >> > >> > >> > >> - > >> Sandra > >> > >> > >> > >> Am 13.01.25 um 14:44 schrieb Slawomir Jaranowski: > >> > >>> On Mon, 13 Jan 2025 at 12:51, Sandra Parsick <spars...@web.de.invalid> > >>> wrote: >>> > >>>> > >>>> > >>>>> Please check, is there a space after ":" > >>>>> > >>>>> > >>>>> > >>>>> "priority: major" - > "priority:major" > >>>>> > >>>>> > >>>>> > >>>>> as defined in: > >>>>> https://github.com/apache/maven-gh-actions-shared/pull/129 > >>>> > >>>> > >>>> > >>>> > >>>> Thanks for the catch. I fixed it. > >>>> > >>>> > >>>> > >>>> > >>>> I did a new test run with all the new configuration fixes. > >>>> > >>>> > >>>> > >>>> Another thing that I recognized: > >>>> Some milestones have label characteristics like > >>>> 'waiting-for-feedback', > >>>> 'more-investigation' or 'backlog' (IMHO). Should they stay as > >>>> milestones, or should they map to (new) labels? > >>> > >>> > >>> > >>> I would like to move it to labels. > >>> We can use a stale action to close inactive issues, pr. > >>> > >>> > >>> > >>>> > >>>> > >>>> > >>>> Am 13.01.25 um 11:12 schrieb Slawomir Jaranowski: > >>>> > >>>>> On Mon, 13 Jan 2025 at 08:51, Sandra Parsick <spars...@web.de.invalid> > >>>>> wrote: >>>>> > >>>>>> > >>>>>> > >>>>>>> Then I think we should use a PR reference instead of a simple link. > >>>>>>> Do you see a problem I did not expect? > >>>>>> > >>>>>> > >>>>>> > >>>>>> I'm fine with that. I have to think about the testing because I > >>>>>> cannot > >>>>>> use the original Jira project because a test run would trigger new > >>>>>> events in the original PR. This would be a waste. > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>>> Should we need to map a priority from JIRA to GitHub issues - it > >>>>>>> can > >>>>>>> be useful information. > >>>>>> > >>>>>> > >>>>>> > >>>>>> Label mapping for priorities is done. > >>>>> > >>>>> > >>>>> > >>>>> Please check, is there a space after ":" > >>>>> > >>>>> > >>>>> > >>>>> "priority: major" - > "priority:major" > >>>>> > >>>>> > >>>>> > >>>>> as defined in: > >>>>> https://github.com/apache/maven-gh-actions-shared/pull/129 > >>>>> > >>>>> > >>>>> > >>>>>> > >>>>>> > >>>>>> Please review the result [1] > >>>>>> > >>>>>> > >>>>>> > >>>>>>>> issues migration is like ARCHETYPE > >>>>>>>> but past milestones have not been imported: > >>>>>>>> https://github.com/support-and-care/mvn-issues-migration-test-mcle > >>>>>>>> an/milestones >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> is it intentional? > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> No, I think my migration config is wrong. I will check it. > >>>>>> > >>>>>> > >>>>>> > >>>>>> It is fixed. See also result [1] > >>>>>> > >>>>>> > >>>>>> > >>>>>> - > >>>>>> Sandra > >>>>>> > >>>>>> > >>>>>> > >>>>>> [1] > >>>>>> https://github.com/support-and-care/mvn-issues-migration-test-mclean/ > >>>>>> issues >>>>>> > >>>>>> > >>>>>> > >>>>>> Am 13.01.25 um 07:42 schrieb Hervé Boutemy: > >>>>>> > >>>>>>> Le dimanche 12 janvier 2025, 09:50:28 CET Sandra Parsick a écrit : > >>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> It appears that link to an external sources have a separate > >>>>>>>>> datatype. > >>>>>>>>> Therefore, the migration tool ignores it. I will fix it (see issue > >>>>>>>>> [1]). > >>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> I solved this issue. I added a new text in the body. Please check > >>>>>>>> it if > >>>>>>>> it is good enough. [1] > >>>>>>> > >>>>>>> great, this new text is perfect to get a link from migrated GHI to > >>>>>>> the PR > >>>>>>> without going to Jira as intermediate (to anticipate a future where > >>>>>>> the Jira server would be taken down) > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> It is possible to add a PR reference to the GitHub issue, but this > >>>>>>>> triggers an event on the original PR. I'm not sure if this behavior > >>>>>>>> is > >>>>>>>> wanted. > >>>>>>> > >>>>>>> we need to refine benefits and drawbacks, to decide what we do: > >>>>>>> from what I see, doing a PR reference from migrated GHI to the PR > >>>>>>> won't change navigation from GHI to PR > >>>>>>> But it will add a navigation back from the PR to the migrated GHI = > >>>>>>> something that is currently missing > >>>>>>> Such back links are normal, and are added whenever someone manually > >>>>>>> add a link to a PR: the fact that in the current case, it would be > >>>>>>> automatic, does not change anything. And such back links will > >>>>>>> happen at migration time only>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Then I think we should use a PR reference instead of a simple link. > >>>>>>> Do you see a problem I did not expect? > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Regards, > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Hervé > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> [1] > >>>>>>>> https://github.com/support-and-care/mvn-issues-migration-test-arche > >>>>>>>> type/issu es/329 > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> Am 11.01.25 um 15:12 schrieb Matthias Bünger: > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>>> I think having the possibility to give issues / PR a priority ist > >>>>>>>>> very > >>>>>>>>> useful in a environment like Maven - but should only be doable by > >>>>>>>>> maintainers (as all labels, except the auto labels when using the > >>>>>>>>> issue > >>>>>>>>> template). > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> Btw labels: I like it very much, that the label for newcomers is > >>>>>>>>> called > >>>>>>>>> "good first issue" and not "up for grabs" (which quite a lot > >>>>>>>>> projects > >>>>>>>>> use, but which has a total different meaning). > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> Am 11.01.2025 um 12:50 schrieb Slawomir Jaranowski: > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>>> Should we need to map a priority from JIRA to GitHub issues - it > >>>>>>>>>> can > >>>>>>>>>> be useful information. > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> If so, we can add labels like - > >>>>>>>>>> https://maven.apache.org/developers/conventions/github.html#Prior > >>>>>>>>>> ity > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On Fri, 10 Jan 2025 at 21:51, Hervé Boutemy > >>>>>>>>>> <herve.bout...@free.fr> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>>> Le mercredi 8 janvier 2025, 18:50:59 CET Sandra Parsick a écrit > >>>>>>>>>>> : > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>>> - ARCHETYPE > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> Migration result: > >>>>>>>>>>>> https://github.com/support-and-care/mvn-issues-migration-test-a > >>>>>>>>>>>> rchetype > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> Used migration config: > >>>>>>>>>>>> https://github.com/support-and-care/jira-to-gh-issues/blob/mast > >>>>>>>>>>>> er/ > >>>>>>>>>>>> src/main/j > >>>>>>>>>>>> ava/io/pivotal/migration/MArchetpeMigrationConfig.java > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> wow, I'm impressed: > >>>>>>>>>>> issues, past closed and still open: > >>>>>>>>>>> https://github.com/support-and-> >>>>>>>>>>> > >>>>>>>>>>> care/mvn-issues-migration-test-archetype/issues?q=is%3Aissue+ > >>>>>>>>>>> past milestones: > >>>>>>>>>>> https://github.com/support-and-care/mvn-issues-> >>>>>>>>>>> > >>>>>>>>>>> migration-test-archetype/milestones?state=closed > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> the only missing aspect I found is when a Jira issue links to a > >>>>>>>>>>> PR, > >>>>>>>>>>> like for example > >>>>>>>>>>> https://issues.apache.org/jira/browse/ARCHETYPE-690 > >>>>>>>>>>> the issue in GH does not display it: > >>>>>>>>>>> https://github.com/support-and-> >>>>>>>>>>> > >>>>>>>>>>> care/mvn-issues-migration-test-archetype/issues/647 > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> with that as a reference, I'm much more confident, once this PR > >>>>>>>>>>> link > >>>>>>>>>>> is solved > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>>> - MCLEAN > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> Migration result: > >>>>>>>>>>>> https://github.com/support-and-care/mvn-issues-migration-test-m > >>>>>>>>>>>> clean > >>>>>>>>>>>> Used migration config: > >>>>>>>>>>>> https://github.com/support-and-care/jira-to-gh-issues/blob/mast > >>>>>>>>>>>> er/ > >>>>>>>>>>>> src/main/j > >>>>>>>>>>>> ava/io/pivotal/migration/MCleanMigrationConfig.java > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> issues migration is like ARCHETYPE > >>>>>>>>>>> but past milestones have not been imported: > >>>>>>>>>>> https://github.com/ > >>>>>>>>>>> support-and-care/mvn-issues-migration-test-mclean/milestones > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> is it intentional? > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>>> - MJLINK > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> Migration result: > >>>>>>>>>>>> https://github.com/support-and-care/mvn-issues-migration-test-m > >>>>>>>>>>>> jlink > >>>>>>>>>>>> Used migration config: > >>>>>>>>>>>> https://github.com/support-and-care/jira-to-gh-issues/blob/mast > >>>>>>>>>>>> er/ > >>>>>>>>>>>> src/main/j > >>>>>>>>>>>> ava/io/pivotal/migration/MJLinkMigrationConfig.java > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> same result as MCLEAN > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> to me, if we fix missing PR links, and import milestones in > >>>>>>>>>>> MCLEAN > >>>>>>>>>>> and MJLINK like it has been done for ARCHETYPE, we can envision > >>>>>>>>>>> wide > >>>>>>>>>>> migration after some time to stress test and learn doing > >>>>>>>>>>> releases > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> for tracking progress, if we can, it would be nice to track in > >>>>>>>>>>> Wiki > >>>>>>>>>>> https://cwiki.apache.org/confluence/display/MAVEN/ > >>>>>>>>>>> JIRA+to+GitHub+Issues+switching > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> I'll add columns for tracking data migration, and lines for the > >>>>>>>>>>> few > >>>>>>>>>>> tests > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> And if we could migrate issues for MPOM and MASFRES, it would be > >>>>>>>>>>> nice > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> Regards, > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> Hervé > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> ---------------------------------------------------------------- > >>>>>>>>>>> ----- > >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>>>>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> ------------------------------------------------------------------ > >>>>>>>>> --- > >>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org > >>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -------------------------------------------------------------------- > >>>>>>> - > >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org > >>>>>>> > >>>>>>> > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> > >>>> > >>>> > >>> > >>> > >>> > >> > >> > >> > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
