Yes, you already pointed to those. I don't really think they apply to our libraries. The reason is that they are usually used as direct dependencies of Maven plugins, which do not share classloaders, so the risk of ending up with the same library from two different coordinates is very minimal. Furthermore, one is for Maven 3 and the other for Maven 4 plugins, and the transitive tree of the maven-archiver 3.x would likely cause much more issues than just the one we would avoid here. Last, the plugin classloader is the responsibility of the plugin writer, and the class loader is definitely not random order, it's the one computed by maven from the POM.
Anyway, I've raised https://github.com/apache/maven-archiver/pull/76 Le mar. 26 nov. 2024 à 15:56, Elliotte Rusty Harold <elh...@ibiblio.org> a écrit : > The issue occurs because now both version 3 and 4 jars can show up in > the classpath, and then it might as well be random which one comes > first and is loaded. If JPMS is in play, split packages can prevent > the app from running at all. > > See https://jlbp.dev/JLBP-6 > > On Tue, Nov 26, 2024 at 1:53 PM Guillaume Nodet <gno...@apache.org> wrote: > > > > Btw, this is a major version bump because the re are incompatible > changes, > > so I’m not really sur how not changing the groupId will really help. You > > may limit the chances you end up with 2 different artifacts, but it won’t > > reduce the chances of having the wrong one. > > > > ------------------------ > > Guillaume Nodet > > > > > > > > Le mar. 26 nov. 2024 à 13:05, Elliotte Rusty Harold <elh...@ibiblio.org> > a > > écrit : > > > > > -1 > > > > > > Changing the group ID without simultaneously changing the package name > > > is a recipe for classpath conflicts and hard to diagnose bugs at > > > runtime. > > > > > > On Tue, Nov 26, 2024 at 10:51 AM Guillaume Nodet <gno...@apache.org> > > > wrote: > > > > > > > > Hi, > > > > > > > > This release mainly updates to Maven 4.0.0-beta-5 (the API is > compatible > > > > with rc-1) and align the groupId. > > > > > > > > Release notes (visibility is limited to committers): > > > > > > > > https://github.com/apache/maven-archiver/releases/edit/untagged-c2daca1bd952f3aa7e9f > > > > > > > > Gist of the above for non committers: > > > > https://gist.github.com/gnodet/d51b135fce0542508e0015efe7a80ef1 > > > > > > > > Staging repo: > > > > https://repository.apache.org/content/repositories/maven-2248/ > > > > > > > > https://repository.apache.org/content/repositories/maven-2248/org/apache/maven/shared/maven-archiver/4.0.0-beta-2/maven-archiver-4.0.0-beta-2-source-release.zip > > > > > > > > Source release checksum: > > > > SHA512(maven-archiver-4.0.0-beta-2-source-release.zip)= > > > > > > > > 4db0088c5f464aa11e2534f5aeffeb9a62046192bc3337af6d72b91e3ae505fe0783e2a8d0e09f065ca1dc745fb2ca71fa5c52897682aae642164527ba15aaf3 > > > > > > > > Staging site: > > > > https://maven.apache.org/shared-archives/maven-archiver-LATEST/ > > > > > > > > Guide to testing staged releases: > > > > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > > > > > The vote will be opened for at least 72 hours. Please review and > vote ! > > > > > > > > -- > > > > ------------------------ > > > > Guillaume Nodet > > > > > > > > > > > > -- > > > Elliotte Rusty Harold > > > elh...@ibiblio.org > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- ------------------------ Guillaume Nodet
