It works when I add …. <pluginManagement> <plugins> <plugin> <groupId>com.diffplug.spotless</groupId> <artifactId>spotless-maven-plugin</artifactId> <configuration> <lineEndings>WINDOWS</lineEndings> </configuration> </plugin>
…. To the pom.xml, so indeed is a line issue. That is a not a nice user experience though, any idea how to a) make spotless normalise line endings before checking or b) remove/skip spotless by default in the pom.xml included in the source-archive.jar? I don’t see an easy way to fix this right now. Konrad > On 26. Sep 2024, at 11:45, Konrad Windszus <k...@apache.org> wrote: > > I cannot rebuild from the source-release.zip. > When building with "mvn package" I get errors from spotless: > > [INFO] --- spotless:2.43.0:check (default) @ maven-fluido-skin --- > [INFO] Index file does not exist. Fallback to an empty index > [INFO] Sorting file > /var/folders/f8/_3c0rvgd00n324sqjc8y_3wr0000gn/T/pom1723467585779815800.xml > [INFO] Pom file is already sorted, exiting > [INFO] Sorting file > /var/folders/f8/_3c0rvgd00n324sqjc8y_3wr0000gn/T/pom8352261247124084601.xml > [INFO] Pom file is already sorted, exiting > [INFO] Spotless.Pom is keeping 1 files clean - 1 needs changes to be clean, 0 > were already clean, 0 were skipped because caching determined they were > already clean > [INFO] Sorting file > /var/folders/f8/_3c0rvgd00n324sqjc8y_3wr0000gn/T/pom6207917468482779990.xml > [INFO] Pom file is already sorted, exiting > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 5.638 s > [INFO] Finished at: 2024-09-26T11:42:59+02:00 > [INFO] > ------------------------------------------------------------------------ > [ERROR] Failed to execute goal > com.diffplug.spotless:spotless-maven-plugin:2.43.0:check (default) on project > maven-fluido-skin: The following files had format violations: > [ERROR] pom.xml > [ERROR] @@ -1,786 +1,786 @@ > [ERROR] -<?xml version="1.0" encoding="UTF-8"?>\r\n > [ERROR] -<!--\r\n > [ERROR] -Licensed to the Apache Software Foundation (ASF) under > one\r\n > [ERROR] -or more contributor license agreements. See the NOTICE > file\r\n > [ERROR] -distributed with this work for additional information\r\n > [ERROR] -regarding copyright ownership. The ASF licenses this > file\r\n > [ERROR] -to you under the Apache License, Version 2.0 (the\r\n > [ERROR] -"License"); you may not use this file except in > compliance\r\n > [ERROR] -with the License. You may obtain a copy of the License > at\r\n > [ERROR] -\r\n > [ERROR] - http://www.apache.org/licenses/LICENSE-2.0\r\n > [ERROR] -\r\n > [ERROR] -Unless required by applicable law or agreed to in > writing,\r\n > [ERROR] -software distributed under the License is distributed on > an\r\n > [ERROR] -"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\r\n > [ERROR] -KIND, either express or implied. See the License for the\r\n > [ERROR] -specific language governing permissions and limitations\r\n > [ERROR] -under the License.\r\n > [ERROR] --->\r\n > [ERROR] -<project xmlns="http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd";>\r\n > [ERROR] - <modelVersion>4.0.0</modelVersion>\r\n > [ERROR] -\r\n > [ERROR] - <parent>\r\n > [ERROR] - <groupId>org.apache.maven.skins</groupId>\r\n > [ERROR] - <artifactId>maven-skins</artifactId>\r\n > [ERROR] - <version>43</version>\r\n > [ERROR] - <relativePath />\r\n > [ERROR] - </parent>\r\n > [ERROR] -\r\n > [ERROR] - <artifactId>maven-fluido-skin</artifactId>\r\n > [ERROR] - <version>2.0.0-M11</version>\r\n > [ERROR] -\r\n > [ERROR] - <name>Apache Maven Fluido Skin</name>\r\n > [ERROR] - <description>The Apache Maven Fluido Skin is an Apache > Maven site skin\r\n > [ERROR] - built on top of Twitter's bootstrap.</description>\r\n > [ERROR] - <inceptionYear>2011</inceptionYear>\r\n > [ERROR] -\r\n > [ERROR] - <contributors>\r\n > [ERROR] - <!-- in alphabetical order -->\r\n > [ERROR] - <contributor>\r\n > [ERROR] - <name>Bruno P. Kinoshita</name>\r\n > [ERROR] - <email>brunodepaulak AT yahoo DOT com DOT > br</email>\r\n > [ERROR] - </contributor>\r\n > [ERROR] - <contributor>\r\n > [ERROR] - <name>Carlos Villaronga</name>\r\n > [ERROR] - <email>cvillaronga AT gmail DOT com</email>\r\n > [ERROR] - </contributor>\r\n > [ERROR] - <contributor>\r\n > [ERROR] ... (1524 more lines that didn't fit) > [ERROR] Run 'mvn spotless:apply' to fix these violations. > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > > > Is this a windows vs Unix line ending issue? > I use > Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) > Maven home: /opt/homebrew/Cellar/maven/3.9.9/libexec > Java version: 11.0.24, vendor: Eclipse Adoptium, runtime: > /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home > Default locale: en_DE, platform encoding: UTF-8 > OS name: "mac os x", version: "14.7", arch: "aarch64", family: “mac" > > Thanks, > Konrad > >> On 26. Sep 2024, at 11:34, Michael Osipov <micha...@apache.org> wrote: >> >> Hi, >> >> we solved 3 issues: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317926&version=12355133 >> >> There are still a couple of issues left in JIRA: >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSKINS%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Fluido%20Skin%22 >> >> Staging repo: >> https://repository.apache.org/content/repositories/maven-2209/ >> https://repository.apache.org/content/repositories/maven-2209/org/apache/maven/skins/maven-fluido-skin/2.0.0-M11/maven-fluido-skin-2.0.0-M11-source-release.zip >> >> Source release checksum(s): >> maven-fluido-skin-2.0.0-M11-source-release.zip >> sha512: >> b7f8519d249a901d96ff7acb67c4847d5a9b6b6670576d3be193edcea8f13d7c585f847f070f5ee3d05df35a9f9cd3896164af641d047dd660945a266f529404 >> >> Staging site: >> https://maven.apache.org/components/skins-archives/maven-fluido-skin-LATEST/ >> >> Guide to testing staged releases: >> https://maven.apache.org/guides/development/guide-testing-releases.html >> >> Vote open for 72 hours. >> >> [ ] +1 >> [ ] +0 >> [ ] -1 >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
