Hi Konrad,

I saw the fork between Maven 3.9.x where I started the documentation job and 
Maven 4:

- Maven 3.9.x: https://github.com/apache/maven/pull/1444
as you can see, requiredMavenVersion exists since 3.0.2
https://issues.apache.org/jira/browse/MNG-4840

- Maven 4: https://github.com/apache/maven/pull/1445
yes, I had to merge and saw you did some improvements

AFAIK, in Maven 4, only requiredJavaVersion was added
what is not clear to me is that it seeems you updated the semantics fo 
requiredMavenVersion in plugin descriptor to be better

i see you found https://github.com/apache/maven/pull/1444 , let's continue the 
discussion here, as I don't know where the issue is yet, but sure, we need to 
clarify

Regards,

Hervé

Le lundi 25 mars 2024, 07:43:18 CET Konrad Windszus a écrit :
> Hi,
> I consider
> https://github.com/apache/maven/commit/740dae43ca3ccf7692f37edf3184387e5666
> ca6b wrong, as in fact the field requiredMavenVersion has been added quite
> recently and is only supported since Maven 4 (for details refer to
> https://issues.apache.org/jira/browse/MNG-7570). The referenced ticket
> https://issues.apache.org/jira/browse/MNG-4840 is only about the
> prerequisites section in the POM. Herve can you revert please? I propose to
> use PRs (even for changes like this) to prevent mistakes like this. Thanks,
> Konrad
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]





---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to