mthmulders commented on a change in pull request #236:
URL: https://github.com/apache/maven-site/pull/236#discussion_r632425862



##########
File path: content/apt/guides/mini/guide-multiple-modules.apt
##########
@@ -59,25 +75,117 @@ Guide to Working with Multiple Modules
 
   Note that only "instantiated" references are used - 
<<<dependencyManagement>>> and <<<pluginManagement>>> elements do not cause a 
change to the reactor sort order.
 
-** Command Line Options
+** Selecting Modules

Review comment:
       We gave it a second thought, and we're not so sure about moving it to 
Maven Embedder or Maven Core. In its current form, the page covers everything a 
Maven user might need: the concepts and how they work together as well as how 
to leverage them by passing the CLI flags.
   
   If we'd move the page to Embedder or Core, it would be strange to have the 
CLI flags mentioned there, as CLI flags only exist in the maven-cli module. It 
would effectively split the page in two: "here's how it works" vs "here's how 
you can use it". We feel it would make it _harder_ for our users to find the 
relevant documentation.
   
   So, we propose to keep it in one page, targeting Maven 4, which would live 
next to the existing page that targets Maven 3. The two pages will 
cross-reference each other:
   
   
![image](https://user-images.githubusercontent.com/430114/118255299-6235ce00-b4ac-11eb-9b83-837278691817.png)
   
   And the two pages will both show up in the menu:
   
   
![image](https://user-images.githubusercontent.com/430114/118255352-737eda80-b4ac-11eb-8345-1174bc7ffd65.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to