abelsromero commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447224575
##########
File path:
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
##########
@@ -179,15 +178,32 @@ protected File getBasedir()
public void parse( String string, Sink sink )
throws ParseException
{
- parse( new StringReader( string ), sink );
+ this.parse( string, sink, null );
}
-
+
+ /**
+ * {@inheritDoc}
+ *
+ * Convenience method to parse an arbitrary string and emit events into
the given sink.
+ *
+ * @param string A string that provides the source input.
+ * @param sink A sink that consumes the Doxia events.
Review comment:
If all the JavaDocs need to be reviewed, these maybe should be addressed
in a specific effort with a specific JIRA issue. I just added the information
related to the new parameter `reference` following the patterns already
pressent in the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
