elharo commented on pull request #3: URL: https://github.com/apache/maven-reporting-exec/pull/3#issuecomment-642632642
For test code it probably doesn't matter, but in general that's not a good idea. Collections.singletonList violates the Liskov Substitution Principle. This is a common design flaw in the Java Collections API and code that uses it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
