The Former Roles chapter on the Project Roles page [1] describes how we work, including the use of Commit Then Review.
Robert [1] https://maven.apache.org/project-roles.html#formal-roles On 31-5-2020 08:00:20, Enrico Olivelli <[email protected]> wrote: Il Dom 31 Mag 2020, 00:57 Olivier Lamy ha scritto: > Hi > First I'm not against PR and people asking review. > But for obvious changes, we can probably avoid PR (ie some spam especially > when people tag you in the description of a PR). > We have a long history about commit-then-review so let's keep this. > > Such change don't really need a PR > https://github.com/apache/maven-site-plugin/pull/26/files > I received around 15 emails for this from github and gitbox (as I was > tagged in the description). > > So please create PR only for complicated change. Yes PR are useful for inline comments and code review One liner changes are not worth, if they are from a committer Enrico Upgrade of a dependency is > NOT a complicated change (except if it breaks backward compat and btw most > of the time there is a Jira for this which generate even more emails). > > I'm just asking to reduce the level of emails we received as at the end the > result is people don't really look at notifications... > > cheers > -- > Olivier Lamy > http://twitter.com/olamy | http://linkedin.com/in/olamy >
