Hi Robert,
having put some more thought into it I was thinking: maybe the IT
should prove that the jira issue integrates with the plugin. In that
case the name would be OK and I would also have a path for providing an
IT for MRELEASE-229. As of now there are no ITs for release:rollback.
I will have to set that up completely from scratch. This will take some
time.
Cheers, Clemens
Am 22.07.2019 um 23:39 schrieb Robert Scholte:
Hi Clemens,
since the codebase is already rather old, you'll see that naming
convention has changed over the years.
Nowadays I prefer to to start with the JIRA id, followed by a very
short statement of the IT.
In the end I'm more important that there is at least a test than the
name.
Just keep in mind that in general things will succeed.
But what if one test breaks for a certain reason.
Having the JIRA id is very handy to identify if you're introducing
regression or not.
thanks,
Robert
On Sun, 14 Jul 2019 12:06:31 +0200, Clemens Quoss <[email protected]>
wrote:
Hello everyone,
one more question regarding the name of the ITs in maven-release (or
maybe generally):
Seeing that the tests are named after the jira issues i am wondering
if that would be the right thing to do.
Shouldn't they be named after the functionality they are testing?
I for my part, being new to the whole thing, have provided a PR for
MRELEASE-229 (implementing RemoveScmTagPhase with some unit tests) [1].
Now i would like to see if there are IT for ScmTagPhase to help me in
my orientation.
For goal prepare there seem to exist the following:
...
10.07.2019 08:16 <DIR> completion-goals
17.02.2019 23:40 <DIR> flat-multi-module
10.07.2019 08:16 <DIR> forked-basic
10.07.2019 08:16 <DIR> invoker-basic
10.07.2019 08:16 833 invoker.properties
10.07.2019 08:15 <DIR> MRELEASE-128
10.07.2019 08:15 <DIR> MRELEASE-156
10.07.2019 08:15 <DIR> MRELEASE-161
10.07.2019 08:15 <DIR> MRELEASE-161-dependencyManagement
10.07.2019 08:15 <DIR> MRELEASE-420
10.07.2019 08:15 <DIR> MRELEASE-483
10.07.2019 08:15 <DIR> MRELEASE-533
10.07.2019 08:15 <DIR> MRELEASE-571_M3
10.07.2019 08:16 <DIR> MRELEASE-618
10.07.2019 08:16 <DIR> MRELEASE-667
17.02.2019 23:40 <DIR> MRELEASE-834
10.07.2019 08:16 <DIR> MRELEASE-966
10.07.2019 08:16 <DIR> MRELEASE-976
10.07.2019 08:16 <DIR> regular-multi-module
...
Maybe one of the MRELEASE-... ITs does something with ScmTagPhase,
maybe not. I will have to look into everyone of them to decide.
Would there be a test or tests named 'scm-tag-phase' or
'scm-tag-phase-MRELEASE-...' this would be of help, at least to me.
Or have I misunderstood some fundamental concept here?
Regards,
Clemens
[1] https://github.com/apache/maven-release/pull/29
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
