Hi, I want to commit this breaking change [1] in checkstyle plugin, that is the upgrade [2] to latest checkstyle (8.x) and thus the making Java 8 the minimum version for the plugin.
Currently I have 3.0.1-SNAPSHOT on master, I think I need to move to 3.1.0-SNAPSHOT. Is is better to bump the version to 3.1.0-SNAPSHOT and then commit the breaking change or commit the change and then commit the new version ? I feel it is better to change the version to 3.1.0-SNAPSHOT and then commit the breaking change. Any review on the PR is well appreciated as well Best regards and Happy Easter ! Enrico [1] https://github.com/apache/maven-checkstyle-plugin/pull/13 [2] https://issues.apache.org/jira/browse/MCHECKSTYLE-366 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
