I have to admit that it still looks weird, but the open and close tags are
balanced.
Also notice that only Java 7 (sometimes) hits this issue.
Gabriel was able to provide a test that always fails on Java 7, not on the
other JDKs.
It must have to do with optimization when the JVM is warmed up.
Anyway, the provided patch takes away the failures and the writing to the
stream is now cleaner too.
You might want to dive into this, but I wonder if it is worth it.
Issue will be resolved with the next release.
thanks,
Robert
On Sat, 08 Dec 2018 12:44:40 +0100, Enrico Olivelli <[email protected]>
wrote:
+1 for Tibor's explanation.
Enrico
Il sab 8 dic 2018, 12:29 Tibor Digana <[email protected]> ha
scritto:
PluginDescriptorGenerator.writeDescriptor does not use Threads so it
must
be the problem that the number of calls "endElement" is greater than
calls
"startElement".
https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java
On Sat, Dec 8, 2018 at 11:46 AM Tibor Digana <[email protected]>
wrote:
> I do not think it can be such JVM issue with string concatenations,
> otherwise
> all the world has the same problem.
> This type of issue is usually caused by multiple writes from multiple
> threads.
> Try to log every method with Thread id and we should see multiple ids.
> The java.io is supposed to be synchronized and thread safe. Therefore
> PrintWriter is a wrapper of thread safe implementations.
> We should use ConcurrentLinkedList and identify large functionality.
If
> large methods changes status at multiple lines, then this is a
critical
> section and the class must be synchronized.
>
> Cheers
> Tibor
>
>
>
>
> --
> Sent from:
http://maven.40175.n5.nabble.com/Maven-Developers-f142166.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
