Please Tibor read the emails and I'm so sorry to repeat again myself but it looks you do not listen anyone... MASTER DOESN'T BUILD!!! using jdk7 or jdk8 or jdk9 or jdk10 I send few links with failure and as far as I can understand from the thread neither Robert can build it!! We must first fix that!!!
On 25 February 2018 at 09:17, Tibor Digana <tibordig...@apache.org> wrote: > Sorry, I have to repeat myself because of undelivered message(s) to Maven > mailing list. > > For clarifying the Surefire goes with Java 6. If you want to run your > tests with JDK10 or lower you have to specify the system property > -Djdk.home=/path/to/jdk10 and the you will see that the tests pass. Go to > target/surefire-reports and failsafe-reports and target/it/** and check the > "java.home" and you will see your /path/to/jdk10. > I KNOW HOW IT WORKS AND AGAIN MY POINT IS whenever jdk you use MASTER DOESN'T BUILD!! > One more remark I got the Jenkins working [1]. The whole problem was with > the call withMaven() in Jenkinsfile. After I switched back to withEnv() the > logs, InterruptedException has gone! > I reported several improvements that Olivier did not like to improve but I > think there is no any significant showstopper for 2.21.0. > I have no idea what you're talking about? Do you have any email threads or jira where I say that? > I will now talk about the Jiras improvements with Olivier in GitHub and I > hope we will make the release soon! > > I still do not understand what codeline you run and why you have problems > with runtime if I did not have several months and I tested with JDK8 u162, > u132, u121. > Please post a link to your codeline because I highly doubt that you are > testing the identical code with me! > PLEASE READ ALL THE PREVIOUS EMAIL I SENT WITH BUILD FAILURE ON PUBLIC JENKINS > > [1]: https://builds.apache.org/job/maven-wip/job/maven-surefire/j > ob/SUREFIRE-1489/ > > For better clarification 2.21.0 is using modulepath - we have integration > test for Jigsaw modularity and modulepath is activated for JDK 9+. > NPE was fixed in 2.21.0 - check the release notes. > We are no more calling the problematic method from commons-lang3 which > caused NPE. This does not require any upgrade of commons-lang3 till 3.0.0. > Please follow the build [1]. > > Cheers > Tibor > > > On Sat, Feb 24, 2018 at 3:22 PM, Robert Scholte <rfscho...@apache.org> > wrote: > >> Hi, >> >> I've noticed some unsatisfying discussions regarding surefire, so let me >> try to help moving this forward. >> > I'm just not happy about how people do not listen neither read emails.... Emails is the primary way of working at Apache because of different timezone etc... IRC is just a volatile dicussion channel when you disconnect you cannot read history, later reply from someone (perso I often shutdown my laptop) > >> Here's the situation as I see it: >> - Surefire 2.20.1 is the latest released version (2017-09-15) >> >> - 2.20.1 doesn't use the modulepath yet, that will be part of the next >> release. A lot of people are waiting for this even before the official >> release of JDK9. >> >> - Surefire 2.x is is still JDK 1.6 compatible, the requirement of JDK 1.7 >> is planned for surefire 3.0.0 >> > I'm fine with that so we can have a branch 2.x with jdk6 compatible And master 3.0.0 with jdk7 requirement. Does it sound reasonnable? > >> - 2.20.1 doesn't run on JDK10, it gets an NPE caused by commons-lang when >> trying to get the Java version. The version of commons-lang where this is >> fixed required JDK 1.7 (which clashes with the previous bullet) >> >> - After the next version (2.21), surefire will focus on 3.0.0 >> >> - There's no agreement that the current master works with JDK10. One of >> the things I noticed is that you need to run surefire with a special set of >> arguments. I haven't been able to build it locally, so I cannot judge it. >> >> - Surefire is a huge, complex project and Tibor has taken the >> responsibility for maintaining this project. >> > I do not see such role at Apache. everyone can work on the project with the same right. There is no BDFL rule and NO one can revert commits from others without discussion. I guess that's the problem here I keep sending emails I have no response!! > >> What I would like to see is: >> - What's blocking a release right now? Is it just CI? Knowing that CI has >> changed a lot the last couple of months, did it just expose *unknown >> issues* compared to 2.20.1? >> - Is the master at its current state already an improvement compared to >> 2.20.1? >> - What would be the estimated release date for surefire. >> - If this date is too unsure or takes too long, can Olivier create a >> branch and do a 21.1-JDK10 release? or beta1? >> >> My main issue is : we should work towards a new release, because 2.20.1 >> doesn't work with JDK10 and there's no workaround. >> IMHO this doesn't have to be an official surefire release, we can add >> some special qualifier to at least help those who need to work with JDK10. >> >> thanks, >> Robert >> > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
