Hi,
a few remarks to the API ( I like the idea of it ).
- use strong() instead of highlight()
- use text() instead of a()
Do we want to be able to nest styles (or mimic it)?
e.g *strong* please ensure to replace this method before *warn* 1-1-2017
*_warn* !!! *_bold*
If so, we'd better use matching closing methods, like we do with Doxia Sink
JANSI api shouldn't be leading, but what we think is general enough for
every ANSI implementation
thanks,
Robert
On Fri, 17 Jun 2016 08:08:54 +0200, Hervé BOUTEMY <herve.bout...@free.fr>
wrote:
there are concepts: that's what the API I propose expose [1]
Name of the different colors can still be refined, I had to find a first
naming
if nobody objets, I'll update Maven core and maven-invoker-plugin with
this
API like I already did in maven-site-plugin [2]
And I think I should be able to implement configuration in settings.xml
(probably not the final version, but a first implementation that will
permit
us easy color schemes testing)
Regards,
Hervé
[1] http://svn.apache.org/viewvc?rev=1748766&view=rev
[2] http://svn.apache.org/viewvc?rev=1748768&view=rev
Le jeudi 16 juin 2016 22:15:20 Christian Schulte a écrit :
Am 06/16/16 um 22:00 schrieb Gary Gregory:
> On Thu, Jun 16, 2016 at 12:55 PM, Christian Schulte <c...@schulte.it>
wrote:
>> Am 06/16/16 um 21:07 schrieb Hervé BOUTEMY:
>>> the second commit makes really things awful here
>>> Sorry, -1, please revert
>>
>> I just reverted both commits. To me it's not clear what the benefit
of
>> colored log messages should be. Having errors in red and warnings in
>> yellow (not just the log level name - the whole message) would make
>> sense as it has an eye-catching effect. Everything else is just
eyecandy
>> without any real benefit even reducing that eye-catching effect.
>
> I disagree. Look how nice Git's color console output is (compared to
all
> one color)
>
> Gary
See the screenshots. GIT appears to have some kind of concept behind
what colour is used for what and when. Compare that to current master.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
