You answered with a condition and an assumption. I’ll be more specific. On a Mac where discovery works well, a new user installs Java, brew installs Maven and it works. Does this still work?
I will check our CI servers, but if those stop working after an upgrade I would be an unhappy user as would the thousands of people using our CI cluster if their jobs broke. I don’t really want to change 400 slaves. I’d have to double check how Java and Maven interact in Jenkins. I’m actually not sure what it does exactly insofar as relying on something set in a plugin, paths or discovery. If you broke how Maven works in CI servers that would not be nice. > On Apr 17, 2016, at 8:37 AM, Michael Osipov <micha...@apache.org> wrote: > > Am 2016-04-17 um 17:24 schrieb Jason van Zyl: >> So will the proposed behavior be I upgrade Maven, I don’t have JAVA_HOME set >> manually and Maven will error out? > > No, if Java in PATH is a JDK, it will continue to work as usual. This is > probably the case on most dev machines. > > Michael > >>> On Apr 15, 2016, at 1:34 PM, Michael Osipov <micha...@apache.org> wrote: >>> >>> Hi folks, >>> >>> we all know that people once in a while complain that my JAVA_HOME is not >>> properly discovered on $PLATFORM, etc. Surprisingly, we require JAVA_HOME >>> to be set in the installation documentation, yet we discover it anyway. >>> This is a contradiction. Moreover, our discovery mechanism can never be >>> complete and won't. It bloats. >>> >>> In MNG-6003 [1], I propose to throw away all of this code and solely rely >>> on the dev's input. If he/she it not able to set it properly, he/she >>> shouldn't write code at all. Most of the time, on Unix/Linux, this isn't >>> even necessary because a JDK is installed by default. >>> >>> I have created a feature branch [1] for this. If no one objects, I will >>> merge this into master. >>> >>> The change have been tested with, without JAVA_HOME and invalid JAVA_HOME on >>> >>> * Windows 10 >>> * Cygwin (Git Bash) >>> * Ubuntu 14.04 LTS (from /home as well as /opt and with symlinks from >>> /usr/local/bin) >>> * FreeBSD 10.2-RELEASE (from /home as well as from /usr/local and with >>> symlinks from /usr/local/bin) >>> >>> Please have a look especially on your platform. >>> >>> Michael >>> >>> [1] https://issues.apache.org/jira/browse/MNG-6003 >>> [2] >>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commitdiff;h=196234a95f7d5ade0b0b905308c2083e856cd121 >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder, Takari and Apache Maven >> http://twitter.com/jvanzyl >> http://twitter.com/takari_io >> --------------------------------------------------------- >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder, Takari and Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io --------------------------------------------------------- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
