It's not completely ugly, but it does entangle dependencies further which I view as ugly.
There is an existing todo above this code to move the validation to a different module, so I believe this will all get removed at that time On Thursday, July 23, 2015, Benson Margulies <bimargul...@gmail.com> wrote: > If this change is so ugly, why are there no comments explaining the ugly? > On Jul 23, 2015 10:48 AM, "jvanzyl" <g...@git.apache.org <javascript:;>> > wrote: > > > Github user jvanzyl commented on the pull request: > > > > https://github.com/apache/maven/pull/60#issuecomment-124129817 > > > > I'm out in the middle of nowhere, but i'll cancel the vote, test and > > re-roll once I'm back to civilization. > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at infrastruct...@apache.org <javascript:;> or > file a JIRA ticket > > with INFRA. > > --- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org <javascript:;> > > For additional commands, e-mail: dev-h...@maven.apache.org > <javascript:;> > > > > > -- Sent from my phone
