As Gary (the only Windows user among the active Log4j maintainers,
AFAIK) has noticed several times, Log4j tests on Windows are pretty
unstable. It not only fails on Gary's laptop, but Piotr and I need to
give Windows tests in CI a kick on a regular basis. Approximately one
out of three CI runs fails on Windows. Piotr already improved the
situation extensively, though there are still several leftovers that
need attention.
Unless somebody steps up to improve the unstable Windows tests, I
would like to disable those only for the WIndows platform.
---------- Forwarded message ---------
From: Gary D. Gregory <ggreg...@apache.org>
Date: Fri, Nov 17, 2023 at 3:03 PM
Subject: Re: [VOTE] Release Apache Log4j 2.22.0
To: <dev@logging.apache.org>
Build failure for me on Windows from the src zip and 'mvn clean verify':
[ERROR] Failures:
[ERROR] RollingAppenderDeleteMaxDepthTest.testAppender:73
[target\rolling-with-delete-depth\test\1,
target\rolling-with-delete-depth\test\2,
target\rolling-with-delete-depth\test\test-1.log,
target\rolling-with-delete-depth\test\test-2.log,
target\rolling-with-delete-depth\test\test-3.log,
target\rolling-with-delete-depth\test\test-4.log] expected:<5> but
was:<6>
[ERROR] RollingAppenderDeleteScriptTest.testAppender:73
target\rolling-with-delete-script\test\test-2.log should have odd
index
[ERROR]
AsyncThreadContextCopyOnWriteTest.testAsyncLogWritesToLog:35->AbstractAsyncThreadContextTestBase.testAsyncLogWritesToLog:171->AbstractAsyncThreadContextTestBase.checkResult:204
[Log file 'AsyncLoggerTest.log']
expected: "INFO c.f.Bar mapvalue [stackvalue] {KEY=mapvalue,
configProp=configValue, configProp2=configValue2} COPY_ON_WRITE
CopyOnWriteSortedArrayThreadContextMap AsyncLoggerContext i=0"
but was: "INFO c.f.Bar mapvalue [stackvalue, stackvalue]
{KEY=mapvalue, configProp=configValue, configProp2=configValue2}
COPY_ON_WRITE CopyOnWriteSortedArrayThreadContextMap
AsyncLoggerContext i=0"
[ERROR]
AsyncThreadContextGarbageFreeTest.testAsyncLogWritesToLog:35->AbstractAsyncThreadContextTestBase.testAsyncLogWritesToLog:171->AbstractAsyncThreadContextTestBase.checkResult:204
[Log file 'AsyncLoggerTest.log']
expected: "INFO c.f.Bar mapvalue [stackvalue] {KEY=mapvalue,
configProp=configValue, configProp2=configValue2} GARBAGE_FREE
GarbageFreeSortedArrayThreadContextMap AsyncLoggerContext i=0"
but was: "INFO c.f.Bar mapvalue [stackvalue, stackvalue]
{KEY=mapvalue, configProp=configValue, configProp2=configValue2}
GARBAGE_FREE GarbageFreeSortedArrayThreadContextMap AsyncLoggerContext
i=0"
[ERROR] Errors:
[ERROR]
AsyncThreadContextCopyOnWriteTest.testAsyncLogWritesToLog:35->AbstractAsyncThreadContextTestBase.testAsyncLogWritesToLog:159
» ConditionTimeout Condition with lambda expression in
org.apache.logging.log4j.core.async.AbstractAsyncThreadContextTestBase
that uses org.apache.logging.log4j.core.jmx.RingBufferAdmin was not
fulfilled within 500 milliseconds.
[ERROR]
AsyncThreadContextGarbageFreeTest.testAsyncLogWritesToLog:35->AbstractAsyncThreadContextTestBase.testAsyncLogWritesToLog:159
» ConditionTimeout Condition with lambda expression in
org.apache.logging.log4j.core.async.AbstractAsyncThreadContextTestBase
that uses org.apache.logging.log4j.core.jmx.RingBufferAdmin was not
fulfilled within 500 milliseconds.
[INFO]
[ERROR] Tests run: 2452, Failures: 4, Errors: 2, Skipped: 35
All that I could capture in the console is here: https://paste.apache.org/k6auj
- Testing src zip file
- OK: ASC verify
- OK SHA check
- mvn clean verify
Using:
Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: C:\java\apache-maven-3.9.5
Java version: 11.0.20, vendor: Eclipse Adoptium, runtime: C:\Program
Files\Eclipse Adoptium\jdk-11.0.20.8-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Microsoft Windows [Version 10.0.19045.3570]
Gary
On 2023/11/17 12:07:06 Volkan Yazıcı wrote:
> This is a vote to release the Apache Log4j 2.22.0.
>
> Website: https://logging.staged.apache.org/log4j
> GitHub: https://github.com/apache/logging-log4j2
> Commit: a1634d695e5702ecab505fea5aadaf9890641487
> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j
> Nexus:
> https://repository.apache.org/content/repositories/orgapachelogging-1238
> Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0
>
> Please download, test, and cast your votes on this mailing list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
>
> This vote is open for 72 hours and will pass unless getting a
> net negative vote count. All votes are welcome and we encourage
> everyone to test the release, but only the Logging Services PMC
> votes are officially counted.
>
> == Review kit
>
> The minimum set of steps needed to review the uploaded distribution
> files can be summarized as follows:
>
> # Verify checksums
> shasum --check *.sha512
>
> # Verify signatures
> for sigFile in *.asc; do gpg --verify $sigFile; done
>
> # Verify reproduciblity
> umask 0022
> unzip *-src.zip -d src
> cd src
> export
> NEXUS_REPO=https://repository.apache.org/content/repositories/orgapachelogging-1238
> sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO
>
> == Release notes
>
> This release provides a CycloneDX Software Bill of Materials (SBOM)[1]
> along with each artifact and contains bug fixes addressing issues in
> the JPMS & OSGi infrastructure overhauled in `2.21.0`, dependency
> updates, and some other minor fixes and improvements.
>
> [1] https://cyclonedx.org/capabilities/sbom
>
> === CycloneDX Software Bill of Materials (SBOM)
>
> This is the first Log4j release that provides a CycloneDX Software
> Bill of Materials (SBOM)[1] along with each artifact. Generated SBOMs
> are attached as artifacts with `cyclonedx` classifier and XML
> extensions, that is, `<artifactId>-<version>-cyclonedx.xml`. They
> contain `vulnerability-assertion` references to a CycloneDX
> Vulnerability Disclosure Report (VDR)[2] that Apache Logging Services
> uses for all projects it maintains. This VDR is accessible through the
> following URL: https://logging.apache.org/cyclonedx/vdr.xml
>
> SBOM generation is streamlined by `logging-parent`, see its website[3]
> for details.
>
> [2] https://cyclonedx.org/capabilities/vdr
> [3] https://logging.apache.org/logging-parent/latest/#cyclonedx-sbom
>
> === Changed
>
> * Change the order of evaluation of `FormattedMessage` formatters.
> Messages are evaluated using `java.util.Format` only if they don't
> comply to the `java.text.MessageFormat` or `ParameterizedMessage`
> format. (#1223)
> * Change default encoding of HTTP Basic Authentication to UTF-8 and
> add `log4j2.configurationAuthorizationEncoding` property to overwrite
> it. (#1970)
> * Update `com.fasterxml.jackson:jackson-bom` to version `2.16.0` (#1974)
> * Update `com.github.luben:zstd-jni` to version `1.5.5-10` (#1940)
> * Update `com.google.guava:guava` to version `32.1.3-jre` (#1875)
> * Update `io.netty:netty-bom` to version `4.1.101.Final` (#1960)
> * Update `org.eclipse.persistence:org.eclipse.persistence.jpa` to
> version `2.7.13` (#1900)
> * Update `org.fusesource.jansi:jansi` to version `2.4.1` (#1907)
> * Update `org.mongodb:bson` to version `4.11.1` (#1957)
> * Update `org.springframework:spring-framework-bom` to version `5.3.30`
> * Update `org.springframework.boot:spring-boot` to version `2.7.17` (#1874)
> * Update `org.springframework:spring-framework-bom` to version `5.3.31`
> (#1973)
> * Update `org.zeromq:jeromq` to version `0.5.4` (#1878)
>
> === Removed
>
> * Removed unused `FastDateParser` which was causing unnecessary heap
> overhead (LOG4J2-3672, #1848)
>
> === Fixed
>
> * Fix MDC pattern converter causing issues for `%notEmpty` (#1922)
> * Export missing OSGi & JPMS modules in `log4j-layout-template-json`
> and `log4j-1.2-api` (#1895)
> * Fix `spring-test` dependency scope change (LOG4J2-3675)
> * Fix JPMS descriptors causing `jlink` issues (#1896)
> * Add missing `Implementation-` and `Specification-` entries to
> `MANIFEST.MF` (implemented by `logging-parent` version `10.3.0`
> update) (#1923)
> * Fix `NotSerializableException` thrown when `Logger` is serialized
> with a `ReusableMessageFactory` (#1884)
>
