I wonder if the moditect plug in would do the heavy lifting for us here. It will automatically generate module info files. That's what we in over at Commons FWIW.
Gary On Sat, Sep 30, 2023, 5:29 PM Piotr P. Karwasz <piotr.karw...@gmail.com> wrote: > Hi Volkan, > > On Thu, 28 Sept 2023 at 15:25, Volkan Yazıcı <vol...@yazi.ci> wrote: > > Please download, test, and cast your votes on this mailing list. > > > > [ ] +1, release the artifacts > > [ ] -1, don't release, because... > > Sorry for joining the party late, but I wanted to perform a test with > Kotlin + JPMS. > > Even if everything else looks fine the module descriptor is: > > module org.apache.logging.log4j.api_kotlin { > requires java.base; > requires kotlin-reflect; > requires kotlin-stdlib; > requires kotlin-stdlib-common; > requires kotlinx-coroutines-core-jvm; > requires log4j-api; > > exports org.apache.logging.log4j.kotlin; > } > > I am afraid I'll have to vote: > > -1, don't release, because the name of the JPMS module for `log4j-api` > is `org.apache.logging.log4j`. > > I only have a basic understanding of Kotlin, but are all those Kotlin > modules required? I believe we could have a basic "Hello world!" > program with just "kotlin-stdlib" and > "org.apache.logging.log4j.api_kotlin". > > Piotr >