Hi Gary,

On Wed, 15 Mar 2023 at 22:58, Gary D. Gregory <ggreg...@apache.org> wrote:
> [INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog ---
> [INFO] Index file does not exist. Fallback to an empty index
> [INFO] Spotless.Java is keeping 24 files clean - 24 needs changes to be 
> clean, 0 were already clean, 0 were skipped because caching determined they 
> were already clean

CRLF, CRLF, CRLF... (or lack of)

By default Spotless respects Git's EOL settings (.gitattributes and
autocrlf). By default Git replaces LF with CRLF when checking out a
Java file. Therefore Spotless expects to find CRLF line endings on
Windows, but finds LF.

I don't know what is the correct solution. We are in 2023, but still
many things depend on the default line endings of the OS (like files
generated by Maven). Maybe we should simplify the problem and:

 * disable line endings conversion in Git,
 * set all the line endings to LF (nobody uses notepad.exe to read Java files).

Piotr

Reply via email to