This is on master. We have tests there that have been failing for quite a while.
Ralph > On Mar 9, 2021, at 2:40 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > It's not innocent of failing the build though ;-) I did not look > closer than noticing that the GitHub builds failed. > > Gary > > On Tue, Mar 9, 2021 at 3:46 PM Volkan Yazıcı <volkan.yaz...@gmail.com> wrote: >> >> The patch "seems" legit to me, but I don't know much about pattern >> converters. >> It is a pretty innocent looking small change – would anybody more >> knowledgeable about the subject mind checking the PR, please? >> >> ---------- Forwarded message --------- >> From: Romain Manni-Bucau <notificati...@github.com> >> Date: Tue, Mar 9, 2021 at 2:17 PM >> Subject: [apache/logging-log4j2] ensure >> EncodingPatternConverter#handlesThrowable is implemented (#473) >> To: apache/logging-log4j2 <logging-log...@noreply.github.com> >> Cc: Subscribed <subscri...@noreply.github.com> >> >> >> Giess the title is enough to understand what happens ;). >> Long story short the handlesThrowable() logic to skip forced (by default) >> append of the exception does not work as soon as encoding is used which is >> almost always the case when outputing JSON/XML using PatternFormatter >> (since Json appender required 3rd party libs which are often undesired). >> This PR implements this method by checking the nested formatters. >> ------------------------------ >> You can view, comment on, or merge this pull request online at: >> >> https://github.com/apache/logging-log4j2/pull/473 >> Commit Summary >> >> - ensure EncodingPatternConverter#handlesThrowable is implemented >> >> File Changes >> >> - *M* >> >> log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/EncodingPatternConverter.java >> >> <https://github.com/apache/logging-log4j2/pull/473/files#diff-5c83513e667e1f6dbdfee6e927df9df827f381495d852e880ed48390c55907db> >> (9) >> - *M* >> >> log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/EncodingPatternConverterTest.java >> >> <https://github.com/apache/logging-log4j2/pull/473/files#diff-86385e7b472324200926d68fe7f3d2b8db3f8ef4557046d616ed716869df802e> >> (39) >> >> Patch Links: >> >> - https://github.com/apache/logging-log4j2/pull/473.patch >> - https://github.com/apache/logging-log4j2/pull/473.diff >> >> — >> You are receiving this because you are subscribed to this thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/logging-log4j2/pull/473>, or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AAARTSM5Z4UNV4Q2LFB6XOTTCYNWLANCNFSM4Y3SU2RA> >> . >
