My +1 as well. I'll finish this release by tomorrow unless someone finds a blocker for some reason.
On Wed, 6 May 2020 at 08:34, Matt Sicker <boa...@gmail.com> wrote: > > IIRC, the site builds as part of a normal build. Did you check the target > directory afterwards? > > On Tue, May 5, 2020 at 16:52 Gary Gregory <garydgreg...@gmail.com> wrote: >> >> +1 but... while everything builds per the instructions I found, it would be >> nice to have something that tells you 'I ran tests and nothing blew up' >> ATM, it just feels like it compiled some stuff and who know if it works. >> >> - Not a blocker: On https://jvz.github.io/log4j-scala-site/#_download update >> the Log4j version to the current version. >> >> - sbt auditCheck >> >> Tells me: >> >> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option >> MaxPermSize=256m; support was removed in 8.0 >> >> Using: >> >> java version "1.8.0_241" >> Java(TM) SE Runtime Environment (build 1.8.0_241-b07) >> Java HotSpot(TM) 64-Bit Server VM (build 25.241-b07, mixed mode) >> >> It would be nice not to get a warning. >> >> - Same for sbt "+ package" >> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option >> MaxPermSize=256m; support was removed in 8.0 >> >> - It would be nice to have Windows version of the build commands to >> simplify cut and paste. >> >> - I was expecting build instructions in the site. For simplicity, looking >> in one place is nice, instead of opening BUILDING.md which then points to >> another file. >> >> Gary >> >> On Sun, May 3, 2020 at 12:51 PM Matt Sicker <boa...@gmail.com> wrote: >> >> > Hello everyone, and welcome to the nth attempt to release this >> > component! This vote is to release 12.0-rc4 of the Log4j Scala API. >> > This vote will remain open for at least 72 hours, requires 3 +1 votes, >> > and more +1 votes than -1 votes. >> > >> > Staging repository: >> > https://repository.apache.org/content/repositories/orgapachelogging-1058 >> > >> > Staging artifacts: >> > https://dist.apache.org/repos/dist/dev/logging/log4j/scala/ >> > >> > Site preview: >> > https://jvz.github.io/log4j-scala-site/ >> > >> > Repository: >> > https://gitbox.apache.org/repos/asf?p=logging-log4j-scala.git >> > >> > Tag: >> > v12.0-rc4 >> > >> > You may download all the Maven artifacts by executing: >> > >> > wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate \ >> > https://repository.apache.org/content/repositories/orgapachelogging-1058 >> > >> > New Features:: >> > LOG4J2-1882::: Migrate log4j-api-scala to sbt. >> > LOG4J2-2303::: Add release distribution script. >> > LOG4J2-2295::: Add OSGi metadata to release jars. >> > LOG4J2-2294::: Add release audit information to build. >> > LOG4J2-2298::: Add changelog to site. >> > LOG4J2-2293::: Add required license files to sbt output artifacts. >> > LOG4J2-2296::: Add sbt-site plugin and website configuration. >> > LOG4J2-2291::: Add Jenkins pipeline for sbt build. >> > LOG4J2-2668::: Add support for Scala 2.13. >> > >> > Changes:: >> > LOG4J2-2309::: Update Log4j Scala API for 2.13 from 2.13.0-M2 to 2.13.0-M3. >> > LOG4J2-2290::: Update Log4j from 2.9.1 to 2.13.2. >> > LOG4J2-1995::: Update log4j-api-scala_2.11 from Scala 2.11.8 to 2.11.11. >> > LOG4J2-1996::: Update log4j-api-scala_2.12 from Scala 2.12.1 to 2.12.3. >> > LOG4J2-2115::: Update Log4j dependency from 2.8.1 to 2.9.1. >> > LOG4J2-2116::: Update log4j-api-scala_2.12 from Scala 2.12.3 to 2.12.4. >> > >> > -- >> > Matt Sicker <boa...@gmail.com> >> > > > -- > Matt Sicker <boa...@gmail.com> -- Matt Sicker <boa...@gmail.com>
